Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge all apispecs correctly #598

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: merge all apispecs correctly #598

merged 1 commit into from
Jan 8, 2025

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Jan 8, 2025

there was a bug in the merging code, the notebooks spec file was saved in the repositories variable overwriting the repositories apispec, so this never ended up on our swagger page.

I rewrote the whole section to make is simpler and prevent this kind of error from happening again in the future.

/deploy

@Panaetius Panaetius requested a review from a team as a code owner January 8, 2025 13:59
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 8, 2025

You can access the deployment of this PR at https://renku-ci-ds-598.dev.renku.ch

Copy link
Member

@eikek eikek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Panaetius Panaetius enabled auto-merge (squash) January 8, 2025 14:12
@Panaetius Panaetius merged commit 4d89038 into main Jan 8, 2025
16 of 19 checks passed
@Panaetius Panaetius deleted the fix-apispec-merge branch January 8, 2025 14:15
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 8, 2025

Tearing down the temporary RenkuLab deplyoment for this PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12672102966

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 86.814%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/blueprints.py 3 92.74%
components/renku_data_services/notebooks/api/schemas/servers_get.py 6 68.31%
Totals Coverage Status
Change from base Build 12653876895: -0.03%
Covered Lines: 15182
Relevant Lines: 17488

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants