-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update project ETag when the namespace slug is changed #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12791037118Details
💛 - Coveralls |
leafty
force-pushed
the
leafty/fix-project-etag
branch
from
January 13, 2025 09:39
02ea479
to
8056245
Compare
leafty
temporarily deployed
to
renku-ci-ds-596
January 13, 2025 09:58 — with
GitHub Actions
Inactive
You can access the deployment of this PR at https://renku-ci-ds-596.dev.renku.ch |
Panaetius
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Just a minor suggestion, feel free to ignore
Co-authored-by: Ralf Grubenmann <[email protected]>
leafty
had a problem deploying
to
renku-ci-ds-596
January 15, 2025 14:57 — with
GitHub Actions
Error
Panaetius
approved these changes
Jan 15, 2025
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #595.
Makes the
etag
value change if the namespace slug changes. This fixes a bug where clients may keep an outdated cached version of aproject
object when the parent namespace gets updated (e.g. the group slug is modified)./deploy