Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update project ETag when the namespace slug is changed #596

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 6, 2025

See #595.

Makes the etag value change if the namespace slug changes. This fixes a bug where clients may keep an outdated cached version of a project object when the parent namespace gets updated (e.g. the group slug is modified).

/deploy

@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12791037118

Details

  • 22 of 23 (95.65%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.003%) to 86.873%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/project/models.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/misc.py 1 98.36%
components/renku_data_services/storage/blueprints.py 2 95.69%
components/renku_data_services/storage/models.py 2 84.11%
Totals Coverage Status
Change from base Build 12786097989: 0.003%
Covered Lines: 15241
Relevant Lines: 17544

💛 - Coveralls

@leafty leafty force-pushed the leafty/fix-project-etag branch from 02ea479 to 8056245 Compare January 13, 2025 09:39
@leafty leafty marked this pull request as ready for review January 13, 2025 09:58
@leafty leafty requested a review from a team as a code owner January 13, 2025 09:58
@leafty leafty temporarily deployed to renku-ci-ds-596 January 13, 2025 09:58 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-596.dev.renku.ch

Panaetius
Panaetius previously approved these changes Jan 15, 2025
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just a minor suggestion, feel free to ignore

components/renku_data_services/utils/etag.py Outdated Show resolved Hide resolved
@leafty leafty merged commit d69ba31 into main Jan 15, 2025
17 checks passed
@leafty leafty deleted the leafty/fix-project-etag branch January 15, 2025 16:00
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants