-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kpack & Shipwright compatible k3d cluster setup #557
Conversation
22c11c0
to
40da545
Compare
40da545
to
6f2a1ba
Compare
4a1af72
to
8234729
Compare
ca32bfa
to
3d31917
Compare
8234729
to
5f3ddf5
Compare
3d31917
to
a2376a9
Compare
46ebfeb
to
41b31b9
Compare
7634433
to
980c77a
Compare
41b31b9
to
7a754c1
Compare
980c77a
to
428d073
Compare
7a754c1
to
8665a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be a bit easier to maintain if the setup-k3d-cluster.sh
script was instead just a python script we invoke with the dev environment?
@olevski sorry for the late reply, I missed the notification. I initially wrote it as a bash script to simplify the Makefile with regard to the waiting phases and customization. I don't mind rewriting it in python but I am not sure to follow the "we invoke with the dev environment". What do you have in mind ? |
I meant the poetry environment that is used every time you do |
I was rather seeing it as a mean to setup your cluster once so you can then use it for development in the same way that is done currently. |
That is how I understood it. And I meant this as a non-blocking question/suggestion. Which I should have clarified earlier. So its not a big deal either way. |
428d073
to
1ecf967
Compare
8665a14
to
0b5ffb5
Compare
since we're leaning more and more towards shipwright instead of kpack, only the registry setup in this PR seems really relevant. But setting up shipwright in a devenv would be nice. |
@Panaetius would you like me to refactor this PR and port it to Shipwright or rather make a new one ? |
I'm fine with either, whichever is easier for you |
0b5ffb5
to
d9edcaf
Compare
1ecf967
to
7a5a79c
Compare
The setup creates an independent k3d registry that can be reused and configures the k3d cluster to be able to access it. The registry thus survives cluster deletion and this will speed up cluster recreation. kpack can access it through http.
7a5a79c
to
1d49642
Compare
d9edcaf
to
ad17872
Compare
The script can now install either shipwright or kpack depending on what should be tested. The Makefile now install shipwright be default
* refactor: implement k3d cluster creation working with kpack and Shipwright The setup creates an independent k3d registry that can be reused and configures the k3d cluster to be able to access it. The registry thus survives cluster deletion and this will speed up cluster recreation. kpack and Shipwrite can access it through http. The script can install either or both solutions. The Makefile installs Shipwright be default
* refactor: implement k3d cluster creation working with kpack and Shipwright The setup creates an independent k3d registry that can be reused and configures the k3d cluster to be able to access it. The registry thus survives cluster deletion and this will speed up cluster recreation. kpack and Shipwrite can access it through http. The script can install either or both solutions. The Makefile installs Shipwright be default
Describe your changes
This PR adds a script that allows to setup a k3d cluster in such a way that kpack and Shipwright can use it.
A k3d registry is created externally so it can be re-used if the cluster must be re-created without incurring the time required to populate it.
kpack and Shipwright can be optionally (and independently) deployed.
In the context of kpack, the image required for the builder is copied to the registry using a Kubernetes job.