Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make resource pool initialisation async #490

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

Panaetius
Copy link
Member

closes #100

/deploy

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-490.dev.renku.ch

@coveralls
Copy link

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11595002577

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bases/renku_data_services/background_jobs/core.py 1 2 50.0%
components/renku_data_services/crc/db.py 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/models.py 1 84.81%
components/renku_data_services/storage/blueprints.py 2 93.18%
components/renku_data_services/crc/blueprints.py 3 93.19%
Totals Coverage Status
Change from base Build 11589126678: -0.02%
Covered Lines: 11110
Relevant Lines: 12231

💛 - Coveralls

@Panaetius Panaetius marked this pull request as ready for review October 29, 2024 13:28
@Panaetius Panaetius requested a review from a team as a code owner October 29, 2024 13:28
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Panaetius Panaetius enabled auto-merge (squash) October 30, 2024 14:12
@Panaetius Panaetius merged commit a8a3326 into main Oct 30, 2024
13 of 14 checks passed
@Panaetius Panaetius deleted the refactor/100-rp-init-async branch October 30, 2024 14:36
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make resource pool initialization async
4 participants