-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REBASE only]: Migrate notebooks and add new amalthea #418
Conversation
30923b5
to
a45bec2
Compare
You can access the deployment of this PR at https://renku-ci-ds-418.dev.renku.ch |
7fcfa17
to
be5272b
Compare
be5272b
to
b1932ee
Compare
b1932ee
to
fd2e56c
Compare
This change is part of the following stack:
Change managed by git-spice. |
fd2e56c
to
df3bb88
Compare
3070da0
to
d2b2d48
Compare
d2b2d48
to
a932966
Compare
This was causing the API to consider some images as non-existing. Whereas in reality they exist. I noticed this with this image: ghcr.io/salimkayal/renku-devcontainer-wizard:latest.
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
Co-authored-by: Samuel Gaist <[email protected]> Co-authored-by: Ralf Grubenmann <[email protected]> Co-authored-by: Flora Thiebaut <[email protected]>
Co-authored-by: Ralf Grubenmann <[email protected]>
36a3e19
to
36e290d
Compare
36e290d
to
2fd571e
Compare
There is a test failing because of this -> #525. |
Co-authored-by: Flora Thiebaut <[email protected]>
2fd571e
to
1046f40
Compare
I saw that I just used a tagged image in the test which passes the tests for now. I dont want to mess with the image checks further here. |
Tearing down the temporary RenkuLab deplyoment for this PR. |
This combines all changes for the notebooks migration and new amalthea operator.
NOTE: This should be rebased on main. DO NOT SQUASH AND MERGE. WHEN updating this branch remember to REABASE only too.
/deploy renku=feat-jupyter-free-sessions amalthea-sessions=main renku-ui=andrea/jupyter-free-build renku-gateway=master extra-values=amalthea-sessions.deployCrd=false