Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REBASE only]: Migrate notebooks and add new amalthea #418

Merged
merged 20 commits into from
Nov 11, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Sep 20, 2024

This combines all changes for the notebooks migration and new amalthea operator.

NOTE: This should be rebased on main. DO NOT SQUASH AND MERGE. WHEN updating this branch remember to REABASE only too.

/deploy renku=feat-jupyter-free-sessions amalthea-sessions=main renku-ui=andrea/jupyter-free-build renku-gateway=master extra-values=amalthea-sessions.deployCrd=false

@olevski olevski requested a review from a team as a code owner September 20, 2024 09:47
@olevski olevski marked this pull request as draft September 20, 2024 09:50
@olevski olevski changed the title Migrate notebooks and add new amalthea [REBASE only]: Migrate notebooks and add new amalthea Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 11782288576

Details

  • 2458 of 3100 (79.29%) changed or added relevant lines in 73 files are covered.
  • 47 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-4.5%) to 86.369%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/authn/gitlab.py 13 14 92.86%
components/renku_data_services/k8s/client_interfaces.py 2 3 66.67%
components/renku_data_services/k8s/clients.py 1 2 50.0%
components/renku_data_services/notebooks/api/classes/cloud_storage/existing.py 7 8 87.5%
components/renku_data_services/notebooks/api/classes/server.py 55 56 98.21%
components/renku_data_services/session/core.py 17 18 94.44%
components/renku_data_services/session/orm.py 23 24 95.83%
components/renku_data_services/storage/blueprints.py 19 20 95.0%
components/renku_data_services/notebooks/api/amalthea_patches/cloudstorage.py 1 3 33.33%
components/renku_data_services/notebooks/api/amalthea_patches/git_proxy.py 16 18 88.89%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/misc.py 1 98.41%
components/renku_data_services/project/db.py 1 93.63%
components/renku_data_services/users/db.py 1 93.77%
components/renku_data_services/authn/keycloak.py 2 47.22%
components/renku_data_services/crc/db.py 2 85.59%
components/renku_data_services/repositories/blueprints.py 2 83.33%
components/renku_data_services/session/db.py 2 89.08%
components/renku_data_services/crc/blueprints.py 3 93.81%
components/renku_data_services/message_queue/config.py 7 70.0%
components/renku_data_services/app_config/config.py 26 90.09%
Totals Coverage Status
Change from base Build 11774232027: -4.5%
Covered Lines: 14991
Relevant Lines: 17357

💛 - Coveralls

@olevski olevski force-pushed the release-amaltheas-migration branch 4 times, most recently from 30923b5 to a45bec2 Compare September 25, 2024 15:17
leafty added a commit that referenced this pull request Sep 26, 2024
Merges:
* #418
* #407

Merge remote-tracking branch 'origin/feat-add-cloudstorage' into leafty/leafty/feat-namespaced-data-connectors-merge-amalthea-migration
@olevski olevski temporarily deployed to renku-ci-ds-418 October 1, 2024 22:57 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Oct 1, 2024

You can access the deployment of this PR at https://renku-ci-ds-418.dev.renku.ch

olevski and others added 11 commits November 11, 2024 14:37
This was causing the API to consider some images as non-existing.
Whereas in reality they exist. I noticed this with this image:
ghcr.io/salimkayal/renku-devcontainer-wizard:latest.
The move of business logic out of the blueprint allows the code to
be reusable without having to go through the web API. It also allows
for tests to be added without the web complexity.

Tests have been refactored so that test clusters will be created only
when testing endpoints that actually require a cluster. This has the
advantage of speeding up test time. This is especially useful when
doing development.

Finally, a new test option has been added so one can use a local
cluster in place of re-creating one each time tests are run.
Co-authored-by: Samuel Gaist <[email protected]>
Co-authored-by: Ralf Grubenmann <[email protected]>
Co-authored-by: Flora Thiebaut <[email protected]>
@olevski olevski force-pushed the release-amaltheas-migration branch from 36a3e19 to 36e290d Compare November 11, 2024 13:45
@olevski olevski requested a review from leafty November 11, 2024 13:45
leafty
leafty previously approved these changes Nov 11, 2024
@leafty
Copy link
Member

leafty commented Nov 11, 2024

There is a test failing because of this -> #525.

@olevski
Copy link
Member Author

olevski commented Nov 11, 2024

There is a test failing because of this -> #525.

I saw that I just used a tagged image in the test which passes the tests for now. I dont want to mess with the image checks further here.

@olevski olevski requested a review from leafty November 11, 2024 16:27
@olevski olevski enabled auto-merge (rebase) November 11, 2024 17:13
@olevski olevski merged commit 1609c03 into main Nov 11, 2024
13 of 17 checks passed
@olevski olevski deleted the release-amaltheas-migration branch November 11, 2024 18:40
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants