Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for sessions in Renku 2.0 #133

Merged
merged 15 commits into from
Mar 14, 2024
Merged

feat: add support for sessions in Renku 2.0 #133

merged 15 commits into from
Mar 14, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 29, 2024 •
edited
Loading

See SwissDataScienceCenter/renku#3475.

  • Adds API endpoints for session environments
  • Adds API endpoints for session launchers

/deploy #notest renku=release-0.50.x

@leafty leafty changed the title feat: add support for sessions in Renku 1.0 feat: add support for sessions in Renku 2.0 Mar 11, 2024
@leafty leafty marked this pull request as ready for review March 13, 2024 14:40
@leafty leafty requested a review from a team as a code owner March 13, 2024 14:40
@coveralls
Copy link

coveralls commented Mar 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8282998327

Details

  • 424 of 468 (90.6%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 88.578%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/session/models.py 41 43 95.35%
components/renku_data_services/session/blueprints.py 86 89 96.63%
components/renku_data_services/session/db.py 111 150 74.0%
Totals Coverage Status
Change from base Build 8267183027: 0.2%
Covered Lines: 5072
Relevant Lines: 5726
💛 - Coveralls

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-133.dev.renku.ch

m-alisafaee
m-alisafaee requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see my comments.

components/renku_data_services/session/models.py Outdated Show resolved Hide resolved
components/renku_data_services/session/db.py
return

authorized = await self.project_authz.has_permission(
user=user, project_id=launcher.project_id, scope=Scope.WRITE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope should be Scope.DELETE here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? Why? This is checking that the user has the write permission on the project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a special permission for delete which we check when deleting a project. Here should be the same I believe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO! I am removing a session launcher, not the project itself.

components/renku_data_services/session/db.py Show resolved Hide resolved
@leafty leafty temporarily deployed to renku-ci-ds-133 March 14, 2024 08:48 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ds-133 March 14, 2024 08:55 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ds-133 March 14, 2024 13:39 — with GitHub Actions Inactive
@leafty leafty requested a review from m-alisafaee March 14, 2024 13:39
@leafty leafty temporarily deployed to renku-ci-ds-133 March 14, 2024 13:55 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ds-133 March 14, 2024 15:05 — with GitHub Actions Inactive
@leafty leafty enabled auto-merge (squash) March 14, 2024 15:39
@leafty leafty merged commit f2155c0 into main Mar 14, 2024
7 checks passed
@leafty leafty deleted the pitch/compute-sessions-final branch March 14, 2024 15:41
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leafty @coveralls @RenkuBot @m-alisafaee