WIP: add ETags #128
WIP: add ETags #128
Conversation
|
You can access the deployment of this PR at https://renku-ci-ds-128.dev.renku.ch |
leafty
had a problem deploying
to
renku-ci-ds-128
GitHub Actions
Failure
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
| @authenticate(self.authenticator) | ||
| @validate(json=apispec.UserPreferencesPatch) | ||
| async def _patch(request: Request, body: apispec.UserPreferencesPatch, user: base_models.APIUser): | ||
| etag = request.headers.get("If-None-Match") |
There was a problem hiding this comment.
I know this isn't done, just as a reminder. we should raise 428 here if an etag is not supplied. maybe with a decorator?
There was a problem hiding this comment.
That is a good question, actually. The way this is written for now is that the use of entity tags on the client side is not mandatory (of course with the risk on mid-air collisions). Their use can be made mandatory if we think all clients can be made to support them.
There was a problem hiding this comment.
I think it should be mandatory. At least I think a client not using etags "winning" when it comes to mid air collisions is exactly the wrong way around for things to be.
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-128
GitHub Actions
Inactive
|
this can be closed, no? |
|
@leafty this can be closed right? |
|
this still contains a prototype to add ETags to the user preferences API. |
WIP/Experimental
/deploy #notest renku=release-0.49.0 renku-ui=leafty/use-etags