Make alertmanager client compile with ghc9 #3
Conversation
upgrade http-cleint increase minimum aeson bound increase version bounds
Add naive shells to allow cabal builds
jappeace
changed the title
| @@ -30,16 +30,16 @@ library | |||
| lib | |||
| ghc-options: -Wall -funbox-strict-fields | |||
| build-depends: | |||
| aeson >=1.0 && <2.0 | |||
| aeson >=2.0 && <3.0 | |||
There was a problem hiding this comment.
Annoying that this big version bump is necessary. I wish the OpenAPI people had supported multiple aeson versions, but it seems that the Aeson maintainers aren't supporting the 1.* releases anymore.
There was a problem hiding this comment.
aeson 1.xx is susceptible to DoS attacks. It's possible to create a universal hash collision for FNV based hash algorithms.
| haskellPackages = (if compiler == "default" | ||
| then pkgs.haskellPackages | ||
| else pkgs.haskell.packages.${compiler}).extend(self: super: { | ||
| alertmanager-openapi = haskellPackages.callPackage ../alertmanager-openapi {}; |
There was a problem hiding this comment.
Why is explicitly adding the package necessary here but not above?
There was a problem hiding this comment.
it's not available in the package set. no-one uploaded it to hackage.
Even if it was you want to override it to the current version in the tree rather then the one on hackage because it may contain changes.
There was a problem hiding this comment.
Sorry, my question wasn't clear - why isn't it necessary to add alertmanager-openapi to the package set when the compiler choice is "default"? It won't be in the Hackage set in either case.
There was a problem hiding this comment.
otherwise cabal can't find it, nix patches cabal somehow
| f = { mkDerivation, alertmanager-openapi, base, http-client, lens | ||
| , lib, text, transformers, cabal-install | ||
| }: | ||
| mkDerivation { | ||
| pname = "alertmanager-client"; | ||
| version = "0.1.0.0"; | ||
| src = ./.; | ||
| libraryToolDepends = [ cabal-install ]; | ||
| libraryHaskellDepends = [ | ||
| alertmanager-openapi base http-client lens text transformers | ||
| ]; | ||
| homepage = "https://github.com/SupercedeTech/alertmanager-client#readme"; | ||
| license = lib.licenses.bsd3; | ||
| }; |
There was a problem hiding this comment.
Why not use callCabal2Nix?
There was a problem hiding this comment.
because many, /many/ more packages are broken, I considered going from me not being able to build it at all to having it generate and build the new bindings good enough for this upgrade cycle.
I made it reproducible with nix.
I allow for cabal builds with dedicated shells.
I extended the documentation in readme.
I fixed all ghc9 compile errors.