BUG: Make sure splitRegion = inputRegion if SplitRegion cannot split, and some ImageSamplerBase style fixes
#1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ThreadIdType` is just a 32-bit (unsigned) integer type: https://github.com/InsightSoftwareConsortium/ITK/blob/7d8b95d705285eb2ddfa3b8bfeb207d69fde0317/Modules/Core/Common/include/itkIntTypes.h#L99
`dynamic_cast` is potentially expensive. Specifically in this case, OutputVectorContainerType (`VectorDataContainer`) is directly derived from DataObject, so there is no need to do any explicit cast at all.
For unsigned integers `i` and `n` greater than zero, `Ceil<unsigned>(i/static_cast<double>(n))` is equivalent to `(i-1)/n + 1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced with pull request #1006 commit 81e5fe8 "STYLE: Rename
SplitRequestedRegionto "SplitRegion", make itstatic", merged 9 December 2023 (my fault).Fortunately the bug seems to rarely cause any problem, as it occurs only when the input region has less than 2 pixels.