Draft: show initial sentences of goal page #40
Conversation
| <input id="goal-page-input" class="box text" placeholder="League of Legends"></input> | ||
| <div id="goal-page-container"> | ||
| <button id="show-goal-text" class="button box" onclick="ToggleGoalSummary()">intro</button> | ||
| <input id="goal-page-input" class="box text" placeholder="League of Legends"></input> |
There was a problem hiding this comment.
something happened with the width here
| #goal-page-container { | ||
| display: flex; | ||
| flex-direction: row; | ||
| gap: 0.5em; | ||
| } | ||
|
|
||
| #goal-page-input { | ||
| flex-grow: 1; | ||
| } |
There was a problem hiding this comment.
obviously this needs to be expanded
| @@ -45,7 +45,12 @@ | |||
| <div class="text">Start a race from</div> | |||
| <input id="start-page-input" class="box text" placeholder="Gingerbread"></input> | |||
| <div class="text">to</div> | |||
| <input id="goal-page-input" class="box text" placeholder="League of Legends"></input> | |||
| <div id="goal-page-container"> | |||
| <button id="show-goal-text" class="button box" onclick="ToggleGoalSummary()">intro</button> | |||
There was a problem hiding this comment.
should the button be just un-clickable or completely hidden before the game has started?
There was a problem hiding this comment.
We can fix a lot of this stuff after the reef.js merge. I think it should just be disabled
|
Honestly when I read about this feature I imagined it would be on the extension side, since not everything that is participating has actually gone to the website... 🤔 But it is certainly easier this way |
|
maybe at some point but right now we don't even show the start and goal page in the extension so we would need to fix that first :p (but i don't think we want all that in the extension, esp. when we have "open lobby") |
Signed-off-by: Victor Löfgren <[email protected]>
the other wikipedia api calls use the i just added a commit which does this, but feel free to implement it properly if you dont think this is good enough |
nice! that was exactly what i wanted :D |
there is an API for checking the initial N sentences of a page! unfortunately CORS means we have to add an endpoint to the backend that proxies this api. i will do that soon.