Add Ruby 3.4 support #275
Open
Add Ruby 3.4 support #275
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abrom Could this be merged and released in rubygems please? Thank you! |
jibiel
reviewed
Jan 3, 2025
| @@ -16,7 +16,7 @@ Gem::Specification.new do |spec| | |||
| SUMMARY | |||
| spec.homepage = 'https://github.com/Studiosity/grover' | |||
| spec.license = 'MIT' | |||
| spec.required_ruby_version = ['>= 3.0.0', '< 3.4.0'] | |||
| spec.required_ruby_version = ['>= 3.0.0', '< 3.5.0'] | |||
There was a problem hiding this comment.
@abrom Any particular reason to lock Ruby version so tightly in this gem?
It'll be the same problem a few months later when 3.5 is released.
The gem prevents apps using it from upgrading Ruby.
There was a problem hiding this comment.
I agree, it is not a reasonable restriction, except in the school of enterprisey business decisions. Please relegate it to the foibles of the Ruby ecosystem's past!
This is blocking upgrades for me, so I may switch to sourcing from a git fork.
|
Any updates on this? |
pboling
suggested changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Ruby 3.4
Fixed #273