-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional combine_pdf + support yarn pnp #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @le0pard 👍
I've got a few suggestions on some copy improvements, but otherwise looking solid
Co-authored-by: Andrew Bromwich <[email protected]>
Co-authored-by: Andrew Bromwich <[email protected]>
Co-authored-by: Andrew Bromwich <[email protected]>
Co-authored-by: Andrew Bromwich <[email protected]>
Thanks @abrom , fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks @le0pard 👍
Released in v1.2.0 |
Reason for this changes
Gem
combine_pdf
needed only for middleware and only forfront_cover
and/orback_cover
functionality. This mean, that people which use grover directly bydisplay_url
or raw html need to have this gem as additional dependency. Problem, thatcombine_pdf
contain as deps https://github.com/caiges/Ruby-RC4 , which is not supported any more (dead dependency).https://github.com/boazsegev/combine_pdf?tab=readme-ov-file#unmaintained---help-wanted -
combine_pdf
also unmaintainedMaintained solutions to use
pdfunite
cli from poppler library or to use https://hexapdf.gettalong.org/examples/merging.html (paid solution)By this proposal I making
combine_pdf
as optional and not install as dependency, so developers, which need middleware andfront_cover
and/orback_cover
functionality can install it separately in application.Also added ability to override js runtime bin, so in this case devs, which use non standard env, like yarn pnp, can override hardcoded
node
bin (example added in README). Possible fix for #262