Skip to content

Commit

Permalink
Fix Bundling. Fixes #50 Fixes #39 Fixes #10.
Browse files Browse the repository at this point in the history
This module uses Infinite Ajax Scroll v2.2.1. All the plugins for
that module (Pagination etc) are not compatible with requireJs because
they are using globals. The only way that this modules JS can access
these globals is by either converting IAS to a requireJs compatible
library or by including the entire file in the infinitescroll.js. This
is a hack, I am aware of that, but until IAS 3.x is available, I think
this at least returns the possiblility to bundle, merge and minify js
again in Magento stores using this plugin.
  • Loading branch information
AntonEvers committed Aug 16, 2019
1 parent 986f601 commit 9186baf
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 20 deletions.
5 changes: 1 addition & 4 deletions view/frontend/requirejs-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ var config = {
infinitescroll: 'Strategery_Infinitescroll/js/infinitescroll'
}
},
paths: {
jqueryIas: 'Strategery_Infinitescroll/js/jquery-ias.min'
},
shim : {
jqueryIas: ['jquery']
infinitescroll: ['jquery']
}
};
18 changes: 15 additions & 3 deletions view/frontend/web/js/infinitescroll.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9186baf

Please sign in to comment.