Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/sabi-157 #161

Merged
merged 22 commits into from
Oct 3, 2024
Merged

feature/sabi-157 #161

merged 22 commits into from
Oct 3, 2024

Conversation

StefanSchubert
Copy link
Owner

Restructured Tests / PatchManagement / PoC of using RestClient instead of RestTemplate for Test in Motd Controller

fixes sabi-113 HTTP.500 after login (returned users)
Adding Spanish resource bundles
Patch-Management on Server Module
Added French, Italian as well
Added flags to the selection dialog
DisplayLanguage is set in it's own Locale.
* sabi-17 i18n of measurement, unit, parameters name and description
- plagues
- parameters
- unit
…gration tests

- Added Testcontainer configuration and a Sample Testclass, as blueprint for the required annotations.
…gration tests

- Refactored UserRepositoryTest, TankRepositoryTest and MeasurementRepositoryTest to use Testcontainer
- Removed H2 from project
…gration tests

- Refactored MeasurementServiceTest
- PatchedSpringBoot to 3.2.3 (required refinement of MAPStruts Mapper)
…gration tests

- Refactored TankServiceTest
- Refactored TestDataFactory
…gration tests

- Refactored test location of controllers
- Migrated NotificationServiceTest
- Migrated FishServiceTest
…gration tests

- Refactored test location of controllers
- Migrated CoralServiceTest
- Introduced first suite classes, for selective test execution.
…gration tests

- MoreSuites
- Service Layer completed
- Next: Module Tests.
…gration tests

- Interlude: PatchManagement SB 3.3.3 etc...
- Next: Module Tests.
…gration tests

- Couldn't Mock Rest API Layer without Testcontainer due to lack of seperation on application context without JPA.
- Experimental refactored MotdControlor to favor the new RestClient istead of RestTemplate.
…gration tests

- Minor Patchmanagement
- Renamed TAGs of APITest to ModuleTest due to issue spec.
…gration tests

- Removed H2 hints in comments
@StefanSchubert StefanSchubert self-assigned this Oct 3, 2024
# Conflicts:
#	captcha/pom.xml
#	sabi-database/src/main/resources/db/migration/version1_3_0/V1_3_0_4__i18nUnit.sql
#	sabi-server/pom.xml
#	sabi-server/src/main/java/de/bluewhale/sabi/mapper/UnitMapper.java
#	sabi-server/src/main/java/de/bluewhale/sabi/persistence/model/LocalizedParameterEntity.java
#	sabi-server/src/main/java/de/bluewhale/sabi/persistence/model/LocalizedUnitEntity.java
#	sabi-server/src/main/java/de/bluewhale/sabi/persistence/model/ParameterEntity.java
#	sabi-server/src/test/java/de/bluewhale/sabi/BasicDataFactory.java
#	sabi-server/src/test/java/de/bluewhale/sabi/services/MeasurementServiceTest.java
#	sabi-webclient/pom.xml
…gration tests

- Test preview switch with maven compiler plugin - java 22 build on github is failing
@StefanSchubert
Copy link
Owner Author

CI is failing since maven-compile-plugin does not support java 22 yet when being executed through this CI runner.
Local maven build
/Users/bluewhale/Library/Java/JavaVirtualMachines/openjdk-22.0.2/Contents/Home/bin/java -Dmaven.multiModuleProjectDirectory=/Users/bluewhale/dev/Intellij-wss/github/sabi/captcha -Djansi.passthrough=true -Dmaven.home=/Applications/IntelliJ IDEA.app/Contents/plugins/maven/lib/maven3 -Dclassworlds.conf=/Applications/IntelliJ IDEA.app/Contents/plugins/maven/lib/maven3/bin/m2.conf -Dmaven.ext.class.path=/Applications/IntelliJ IDEA.app/Contents/plugins/maven/lib/maven-event-listener.jar -javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=64985:/Applications/IntelliJ IDEA.app/Contents/bin -Dfile.encoding=UTF-8 -Dsun.stdout.encoding=UTF-8 -Dsun.stderr.encoding=UTF-8 -classpath /Applications/IntelliJ IDEA.app/Contents/plugins/maven/lib/maven3/boot/plexus-classworlds.license:/Applications/IntelliJ IDEA.app/Contents/plugins/maven/lib/maven3/boot/plexus-classworlds-2.8.0.jar org.codehaus.classworlds.Launcher -Didea.version=2024.2.3 --update-snapshots -s /Users/bluewhale/.m2/settings.xml -DskipTests=true compile -P !owasp-check
however is successful. I decided to ignore the failing GitHub pipeline this time.

@StefanSchubert StefanSchubert merged commit e2b6adb into main Oct 3, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant