Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for subscribing to callbacks that return Task #1486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for subscribing to callbacks that return Task #1486

wants to merge 1 commit into from
+141 −8

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jan 4, 2025

@yaakov-h what do you think will this work?

Fixes #1464

@xPaw xPaw force-pushed the async-callbacks branch from 6cc713b to d7003ba Compare January 4, 2025 11:46
@yaakov-h
Copy link
Member

yaakov-h commented Jan 5, 2025

I don't like blocking waiting for the task, but since we want thread affinity.. 🤔

Might be worth converting all callbacks to ValueTask.

@xPaw
Copy link
Member Author

xPaw commented Jan 5, 2025

I don't like blocking waiting for the task

Non task callbacks already block, so not sure what difference that makes here.

Might be worth converting all callbacks to ValueTask.

How would that look?

@xPaw xPaw force-pushed the async-callbacks branch from 4c70d61 to 5dcf77a Compare January 5, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CallbackMgr: Allow subscribing to callbacks that return Task
2 participants
@xPaw @yaakov-h