refactor: Parse ev args

Fixes #96
StarCitizenWiki · Jul 14, 2024 · 0eff8e9 · 0eff8e9
1 parent f84c125
commit 0eff8e9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/includes/EmbedService/EmbedHtmlFormatter.php b/includes/EmbedService/EmbedHtmlFormatter.php
@@ -194,8 +194,8 @@ public static function makeThumbHtml( AbstractEmbedService $service ): string {
 
 			// phpcs:disable
 			return <<<HTML
-				<picture class="embedvideo-thumbnail">
-					<img src="{$url}" loading="lazy" class="embedvideo-thumbnail__image" alt="Thumbnail for {$service->getTitle()}"/>
+				<picture class="embedvideo-thumbnail"><!--
+				--><img src="{$url}" loading="lazy" class="embedvideo-thumbnail__image" alt="Thumbnail for {$service->getTitle()}"/>
 				</picture>
 				HTML;
 			// phpcs:enable

diff --git a/includes/EmbedVideo.php b/includes/EmbedVideo.php
@@ -120,7 +120,7 @@ public static function parseEV( Parser $parser, PPFrame $frame, array $args, boo
 		foreach ( $args as $key => $arg ) {
 			$value = trim( $frame->expand( $arg ) );
 			if ( $fromTag === true ) {
-				$expandedArgs[$key] = $value;
+				$expandedArgs[$key] = $parser->recursiveTagParse( $value, $frame );
 			} else {
 				$expandedArgs[] = $value;
 			}