fix: Don't try to transform bool

Fixes #93
StarCitizenWiki · Apr 28, 2024 · 05575f8 · 05575f8
1 parent 40f5a00
commit 05575f8
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/includes/Media/VideoHandler.php b/includes/Media/VideoHandler.php
@@ -73,21 +73,23 @@ public function normaliseParams( $image, &$params ): bool {
 
 			if ( $title !== null && $title->exists() ) {
 				$coverFile = MediaWikiServices::getInstance()->getRepoGroup()->findFile( $title );
-				$transform = $coverFile->transform( [ 'width' => $params['width'] ] );
 
-				try {
-					$params['posterUrl'] = MediaWikiServices::getInstance()->getUrlUtils()->expand(
-						$transform->getUrl()
-					);
+				if ( !$coverFile !== false ) {
+					$transform = $coverFile->transform( [ 'width' => $params['width'] ] );
 
-				} catch ( Exception $e ) {
-					unset( $params['poster'], $params['posterUrl'] );
+					try {
+						$params['posterUrl'] = MediaWikiServices::getInstance()->getUrlUtils()->expand(
+							$transform->getUrl()
+						);
+					} catch ( Exception $e ) {
+						unset( $params['posterUrl'] );
+					}
 				}
-			} else {
-				unset( $params['poster'] );
 			}
 		}
 
+		unset( $params['poster'] );
+
 		if ( isset( $params['lazy'] ) ) {
 			$params['lazy'] = true;
 		} else {