Commit
Since clientPrefs and other related features are not avaliable until MW 1.42, many of them are backported as polyfill. Instead of using cookies, the polyfill are using localStorage only like Citizen in the past. There are many changes behind the scene, but the most important one being that `skin-citizen-*` theme classes are now soft-deprecated, and replaced by the standardized `skin-theme-clientpref-*` classes. There will be sufficient time before the hard deprecation. Related: #780
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,12 +43,15 @@ | |
| "citizen-tagline-ns-help": "Help page", | ||
| "citizen-tagline-ns-category": "Category page", | ||
| "citizen-tagline-user-regdate": "Joined $1", | ||
| "prefs-citizen-fontsize-label": "Font size", | ||
| "prefs-citizen-pagewidth-label": "Page width", | ||
| "prefs-citizen-lineheight-label": "Line height", | ||
| "prefs-citizen-resetbutton-label": "Reset to default", | ||
|
|
||
| "skin-theme-name": "Color", | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
alistair3149
Author
Member
|
||
| "skin-theme-description": "Reduces the light emitted by device screens.", | ||
| "skin-theme-day-label": "Day", | ||
| "skin-theme-night-label": "Night", | ||
| "skin-theme-os-label": "Automatic", | ||
| "skin-theme-exclusion-notice": "This page is always in day mode." | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| /** | ||
| * TODO: Revisit when we move to MW 1.43 and the interface is more stable | ||
| */ | ||
|
|
||
| /** | ||
| * Creates default portlet. | ||
| * Based on Vector | ||
| * | ||
| * @param {Element} portlet | ||
| * @return {Element} | ||
| */ | ||
| function addDefaultPortlet( portlet ) { | ||
| const ul = portlet.querySelector( 'ul' ); | ||
| if ( !ul ) { | ||
| return portlet; | ||
| } | ||
| ul.classList.add( 'citizen-menu__content-list' ); | ||
| const label = portlet.querySelector( 'label' ); | ||
| if ( label ) { | ||
| const labelDiv = document.createElement( 'div' ); | ||
| labelDiv.classList.add( 'citizen-menu__heading' ); | ||
| labelDiv.innerHTML = label.textContent || ''; | ||
| portlet.insertBefore( labelDiv, label ); | ||
| label.remove(); | ||
| } | ||
| let wrapper = portlet.querySelector( 'div:last-child' ); | ||
| if ( wrapper ) { | ||
| ul.remove(); | ||
| wrapper.appendChild( ul ); | ||
| wrapper.classList.add( 'citizen-menu__content' ); | ||
| } else { | ||
| wrapper = document.createElement( 'div' ); | ||
| wrapper.classList.add( 'citizen-menu__content' ); | ||
| ul.remove(); | ||
| wrapper.appendChild( ul ); | ||
| portlet.appendChild( wrapper ); | ||
| } | ||
| portlet.classList.add( 'citizen-menu' ); | ||
| return portlet; | ||
| } | ||
|
|
||
| /** | ||
| * Polyfill for mw.util.addPortlet for < MW 1.42 | ||
| * | ||
| * @return {Element} | ||
| */ | ||
| function addPortlet() { | ||
| if ( mw.util.addPortlet ) { | ||
| return addDefaultPortlet( mw.util.addPortlet ); | ||
| } | ||
|
|
||
| return function ( id, label, before ) { | ||
| const portlet = document.createElement( 'div' ); | ||
| portlet.classList.add( 'mw-portlet', 'mw-portlet-' + id, 'emptyPortlet', | ||
| // Additional class is added to allow skins to track portlets added via this mechanism. | ||
| 'mw-portlet-js' | ||
| ); | ||
| portlet.id = id; | ||
| if ( label ) { | ||
| const labelNode = document.createElement( 'label' ); | ||
| labelNode.textContent = label; | ||
| portlet.appendChild( labelNode ); | ||
| } | ||
| const listWrapper = document.createElement( 'div' ); | ||
| const list = document.createElement( 'ul' ); | ||
| listWrapper.appendChild( list ); | ||
| portlet.appendChild( listWrapper ); | ||
| if ( before ) { | ||
| let referenceNode; | ||
| try { | ||
| referenceNode = document.querySelector( before ); | ||
| } catch ( e ) { | ||
| // CSS selector not supported by browser. | ||
| } | ||
| if ( referenceNode ) { | ||
| const parentNode = referenceNode.parentNode; | ||
| parentNode.insertBefore( portlet, referenceNode ); | ||
| } else { | ||
| return null; | ||
| } | ||
| } | ||
| mw.hook( 'util.addPortlet' ).fire( portlet, before ); | ||
| return addDefaultPortlet( portlet ); | ||
| }; | ||
| } | ||
|
|
||
| /** @module addPortlet */ | ||
| module.exports = addPortlet; |
These keys are already used by the Vector skin and causes issues in translatewiki.net: PHP Notice: Key 8:skin-theme-name already belongs to mediawiki-skin-vector, conflict with mwgithub-star-citizen.
Do you need these to be translated separately or not translated?