feat(core): add config to use numberformatter without disabling sites…

…tats

Add the ability to disable numberformatter independently from sitestats
Due to an upstream issue, numberforrmatter can throw an exception in some
instances (#474). This will help to mitigate the issue.

README.md

@@ -93,6 +93,7 @@ Name | Description | Values | Default
 `$wgCitizenShowPageTools` | The condition of page tools visibility | `true` - always visible; `login` - visible to logged-in users; `permission` - visible to users with the right permissions | `true`
 `$wgCitizenSiteToolsPortlet` | ID of the portlet to attach the site tools | string |
 `$wgCitizenEnableDrawerSiteStats` | Enables the site statistics in drawer menu | `true` - enable; `false` - disable | `true`
+`$wgCitizenUseNumberFormatter` | Use NumberFormatter for site statistics, which allows formatting number in a localized way | `true` - enable; `false` - disable | `true`
 `$wgCitizenThemeColor` | The color defined in the `theme-color` meta tag | Hex color code | `#131a21`
 
 ### Search suggestions

includes/Partials/Drawer.php

@@ -175,7 +175,7 @@ private function getSiteStatsData(): array {
 			$fmt = null;
 
 			// Get NumberFormatter here so that we don't have to call it for every stats
-			if ( class_exists( \NumberFormatter::class ) ) {
+			if ( $this->getConfigValue( 'CitizenUseNumberFormatter' ) && class_exists( \NumberFormatter::class ) ) {
 				$locale = $skin->getLanguage()->getHtmlCode() ?? 'en_US';
 				$fmt = new \NumberFormatter( $locale, \NumberFormatter::PADDING_POSITION );
 				$fmt->setAttribute( \NumberFormatter::ROUNDING_MODE, \NumberFormatter::ROUND_DOWN );

skin.json

@@ -749,6 +749,12 @@
 			"description": "Enables the site statistics in drawer menu",
 			"descriptionmsg": "citizen-config-enabledrawersitestats",
 			"public": true
+		},
+		"UseNumberFormatter": {
+			"value": true,
+			"description": "Use NumberFormatter for site statistics",
+			"descriptionmsg": "citizen-config-usenumberformatter",
+			"public": true
 		}
 	},
 	"manifest_version": 2