fix deletion of HealthKit-connected apps #28
+134
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaskollmer
changed the title
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 85.66% 84.99% -0.67%
==========================================
Files 5 10 +5
Lines 251 333 +82
==========================================
+ Hits 215 283 +68
- Misses 36 50 +14
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Supereg
approved these changes
Jan 16, 2025
PSchmiedmayer
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Nice, thank you for that fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix deletion of HealthKit-connected apps
♻️ Current situation & Problem
Deleting an app that has saved data to HealthKit triggers an alert informing the user that the app's health data will remain in the HealthKit database, even when the app is deleted.
This alert is currently not dismissed when deleting an app, which can mess up subsequent queries/interactions/steps in a UITest.
⚙️ Release Notes
📚 Documentation
The documentation is unchanged, since this PR doesn't make any changes to the public interface of the package.
✅ Testing
There is a new test case that adds a heart rate sample to the health store, and then deletes the app.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: