Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly increase the default timeout for precondition assertions #17

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 15, 2024

Slightly increase the default timeout for precondition assertions

♻️ Current situation & Problem

This PR increases the default timeout from 0.01s to 1s. In the last few days, tests were sometimes failing as XCTRuntimePrecondition failed to result in a precondition in the specified timeout. Therefore, we increase the default timeout to a less restrictive value.

⚙️ Release Notes

  • Increase default timeout from 0.01s to 1s for XCTRuntimePrecondition.

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer August 15, 2024 13:29
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (a2b1275) to head (087c840).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files           8        8           
  Lines         305      305           
=======================================
  Hits          279      279           
  Misses         26       26           
Files Coverage Δ
.../XCTRuntimeAssertions/XCTRuntimePrecondition.swift 98.08% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b1275...087c840. Read the comment docs.

@Supereg Supereg merged commit f560ec8 into main Aug 15, 2024
11 checks passed
@Supereg Supereg deleted the fix/increase-default-timeout branch August 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants