Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be less strict about the requested SwiftLint version #16

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 13, 2024

Be less strict about the requested SwiftLint version

♻️ Current situation & Problem

We currently fixed SwiftLint at upToNextMinor. This makes it harder for projects depending on XCTRuntimeAssertions to upgrade their swiftlint version (and SwiftSyntax version). Also the CI always uses the latest version. Therefore, we accept just any 0.x release.

⚙️ Release Notes

  • Be less strict about the requested SwiftLint version

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg self-assigned this Aug 13, 2024
@Supereg Supereg requested a review from PSchmiedmayer August 13, 2024 06:39
@Supereg
Copy link
Member Author

Supereg commented Aug 13, 2024

It seems like visionOS and watchOS simulators aren't installed anymore?

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good; thank you!

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (7ce2801) to head (52738e8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files           8        8           
  Lines         305      305           
=======================================
  Hits          279      279           
  Misses         26       26           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce2801...52738e8. Read the comment docs.

@PSchmiedmayer
Copy link
Member

I re-installed the simulators on all runners @Supereg.

@Supereg
Copy link
Member Author

Supereg commented Aug 14, 2024

I re-installed the simulators on all runners @Supereg.

Thank you 🚀

@Supereg Supereg merged commit a2b1275 into main Aug 14, 2024
11 checks passed
@Supereg Supereg deleted the fix/swiftlint-version branch August 14, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants