Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial connection to the BioPot #41

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Initial connection to the BioPot #41

merged 8 commits into from
Nov 17, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 15, 2023

Initial connection to the BioPot

♻️ Current situation & Problem

This PR adds some very basic and initial connection mechanism to NAMS to connect to the BioPot based on SpeziBluetooth 🚀

⚙️ Release Notes

  • Added initial support for BioPot based on SpeziBluetooth.
  • Added some first characteristic models for encoding and decoding.

📚 Documentation

Minimal documentation was added where necessary. A lot of context is tracked within our Notion space.

✅ Testing

We added a initial setup for unit testing as well as a basic UI test!

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #41 (88bb541) into main (f992823) will decrease coverage by 0.06%.
The diff coverage is 83.97%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   85.72%   85.65%   -0.06%     
==========================================
  Files          67       72       +5     
  Lines        2457     2668     +211     
==========================================
+ Hits         2106     2285     +179     
- Misses        351      383      +32     
Files Coverage Δ
NAMS/Bluetooth/BluetoothManager.swift 100.00% <100.00%> (ø)
NAMS/EEG/EEGDeviceDetails.swift 78.03% <100.00%> (+0.44%) ⬆️
NAMS/Home.swift 92.76% <100.00%> (+0.57%) ⬆️
NAMS/NAMSAppDelegate.swift 97.68% <100.00%> (+1.01%) ⬆️
NAMS/BioPot/Model/DeviceConfiguration.swift 95.35% <95.35%> (ø)
NAMS/BioPot/Model/DeviceInformation.swift 92.00% <92.00%> (ø)
NAMS/EEG/BatteryIcon.swift 79.32% <79.32%> (ø)
NAMS/BioPot/BiopotDevice.swift 73.81% <73.81%> (ø)
NAMS/BioPot/Biopot.swift 77.93% <77.93%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f992823...88bb541. Read the comment docs.

@Supereg Supereg force-pushed the feature/initial-biopot branch from cd1fdd3 to 5c543d2 Compare November 17, 2023 06:58
@Supereg Supereg marked this pull request as ready for review November 17, 2023 22:12
@Supereg Supereg merged commit d47ccf3 into main Nov 17, 2023
7 checks passed
@Supereg Supereg deleted the feature/initial-biopot branch November 17, 2023 23:06
@Supereg Supereg mentioned this pull request Dec 2, 2023
1 task
Supereg added a commit that referenced this pull request Dec 5, 2023
# Visualize Biopot measurements

## ♻️ Current situation & Problem
The biopot device integration is currently relatively limited. With #41
we introduced initial pairing functionality based on SpeziBluetooth and
#45 introduced parsing the BLE layer. This PR does first steps to
integrate the Biopot device into the existing device search
infrastructure and aims to display live data from the device.


## ⚙️ Release Notes 
* Integrate Biopot devices into the nearby devices list.
* Visualize live measurements from the currently connected Biopot.


## 📚 Documentation
--


## ✅ Testing
_TBA_


### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant