-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/weightscale_bluetooth #6
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
===========================================
+ Coverage 23.37% 52.72% +29.36%
===========================================
Files 27 32 +5
Lines 856 1159 +303
===========================================
+ Hits 200 611 +411
+ Misses 656 548 -108
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nriedman Amazing work with this PR for the first time working with Spezi Bluetooth and extending the app with this functionality.
I had a few comments across the PR that would be great to be addressed and would benefit the current logic and overall structure.
Let me know if you have any questions and feel free to re-request a review once you have addressed the different elements in this PR.
ENGAGEHF/Bluetooth/Devices/WeightScale/Characteristics/WeightMeasurement.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nriedman Thank you for all the improvements. I only had a few smaller comments that would be great to be addressed before the PR is merged 👍
Apart from these comments, feel free to merge the PR once they are addressed; great job!
Co-authored-by: Paul Schmiedmayer <[email protected]>
…NGAGE-HF into feature/bluetooth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the addition improvements @nriedman!
Connect to weight scale, Save and display recorded measurements
♻️ Current situation & Problem
Currently, the application is unable to connect to the weight scale, record weight measurements, and save them to cloud storage.
⚙️ Release Notes
📚 Documentation
More thorough in-line documentation will be included along with testing in the next PR.
✅ Testing
UI Tests will be implemented in the next PR.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: