-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/UI-updates #117
fix/UI-updates #117
Conversation
@PSchmiedmayer Everything looks good to go! Some of the UI Tests are failing for the same reasons as the other PR, so once we merge that this one can shortly follow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work @nriedman!
I have also taken a look at most of the UI tests and could reduce it a few that are left.
I think the UI changes PR should pass or only have one test that is unstable; please double check this after all the other UI changes here.
ENGAGEHF/Medications/ColorLegendSection/ColorKeyEntryView.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 79.05% 78.39% -0.65%
==========================================
Files 149 149
Lines 5112 5155 +43
==========================================
Hits 4041 4041
- Misses 1071 1114 +43
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Incorporate UI Feedback
♻️ Current situation & Problem
We've received several points of feedback related to UI (see Issues #106, #116, #113).
⚙️ Release Notes
Addressed the following Issues:
Also removed template text from the onboarding flow.
📚 Documentation
For the medications page:
To summarize, the problem we were seeing was that medication recommendations of types
moreLabObservationsRequired
andmorePatientObservationsRequired
were being styled with the same color asimprovementAvailable
. However, it's possible for medications that the patient has not started yet to be in these states, while the explanation associated with that color described it as "On the med but may benefit from a higher dose."To address this, I went ahead and added a 4th possible state for styling --
actionRequired
. This bucket captures the cases where we don't know enough to give a recommendation, regardless of whether the patient has started the medication or not. I've styled it a soft blue, and included an entry in the color legend to explain it.The medications and dizziness graph pages now looks like this:
✅ Testing
Updated UI tests to reflect changes. Added a regression test to make sure the educational videos appear on sign up with a new invitation code.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: