Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/UI-updates #117

Merged
merged 22 commits into from
Dec 22, 2024
Merged

fix/UI-updates #117

merged 22 commits into from
Dec 22, 2024

Conversation

nriedman
Copy link
Contributor

@nriedman nriedman commented Nov 26, 2024

Incorporate UI Feedback

♻️ Current situation & Problem

We've received several points of feedback related to UI (see Issues #106, #116, #113).

⚙️ Release Notes

Addressed the following Issues:

Also removed template text from the onboarding flow.

📚 Documentation

For the medications page:

To summarize, the problem we were seeing was that medication recommendations of types moreLabObservationsRequired and morePatientObservationsRequired were being styled with the same color as improvementAvailable. However, it's possible for medications that the patient has not started yet to be in these states, while the explanation associated with that color described it as "On the med but may benefit from a higher dose."

To address this, I went ahead and added a 4th possible state for styling -- actionRequired. This bucket captures the cases where we don't know enough to give a recommendation, regardless of whether the patient has started the medication or not. I've styled it a soft blue, and included an entry in the color legend to explain it.

The medications and dizziness graph pages now looks like this:

new-medications-top new-medications-bottom
new-dizziness-label

✅ Testing

Updated UI tests to reflect changes. Added a regression test to make sure the educational videos appear on sign up with a new invitation code.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@nriedman
Copy link
Contributor Author

@PSchmiedmayer Everything looks good to go! Some of the UI Tests are failing for the same reasons as the other PR, so once we merge that this one can shortly follow.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the work @nriedman!

I have also taken a look at most of the UI tests and could reduce it a few that are left.
I think the UI changes PR should pass or only have one test that is unstable; please double check this after all the other UI changes here.

ENGAGEHF/HeartHealth/SelectionTypes/SymptomsType.swift Outdated Show resolved Hide resolved
ENGAGEHF/Medications/RecommendationStyle.swift Outdated Show resolved Hide resolved
ENGAGEHF/Medications/RecommendationStyle.swift Outdated Show resolved Hide resolved
ENGAGEHF/Managers/VideoManager/VideoManager.swift Outdated Show resolved Hide resolved
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Dec 4, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.39%. Comparing base (532d7e7) to head (2aa19a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...artHealth/Symptoms/AnyAxisContent+CustomAxes.swift 96.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   79.05%   78.39%   -0.65%     
==========================================
  Files         149      149              
  Lines        5112     5155      +43     
==========================================
  Hits         4041     4041              
- Misses       1071     1114      +43     
Files with missing lines Coverage Δ
ENGAGEHF/ContentView.swift 93.75% <100.00%> (-0.12%) ⬇️
...GEHF/HeartHealth/SelectionTypes/SymptomsType.swift 70.46% <100.00%> (ø)
...HF/HeartHealth/Symptoms/SymptomsGraphSection.swift 63.83% <100.00%> (ø)
...GAGEHF/HeartHealth/Vitals/VitalsGraphSection.swift 97.23% <100.00%> (ø)
...anagers/MedicationsManager/MedicationDetails.swift 94.00% <100.00%> (ø)
...nagers/MedicationsManager/MedicationsManager.swift 74.76% <100.00%> (+2.03%) ⬆️
ENGAGEHF/Managers/VideoManager/VideoManager.swift 93.19% <ø> (ø)
...cations/ColorLegendSection/ColorKeyEntryView.swift 100.00% <100.00%> (ø)
...F/Medications/ColorLegendSection/ColorLegend.swift 100.00% <100.00%> (ø)
ENGAGEHF/Medications/RecommendationStyle.swift 100.00% <100.00%> (ø)
... and 1 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532d7e7...2aa19a8. Read the comment docs.

@nriedman nriedman merged commit 914e5dc into main Dec 22, 2024
7 checks passed
@nriedman nriedman deleted the spezi/extract-components branch December 22, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants