Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested directories in "NPM Publish package" #98

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

arkadiuszbachorski
Copy link
Contributor

@arkadiuszbachorski arkadiuszbachorski commented Jan 22, 2025

Support nested directories in "NPM Publish package"

♻️ Current situation & Problem

If NPM package is nested deeply into repository, there is a need to specify working directory and cache-dependency-path.

⚙️ Release Notes

  • Add cache dependency path param to "NPM Publish package"
  • Improve NPM token description
  • Add working directory param

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@arkadiuszbachorski arkadiuszbachorski changed the title Add cache dependency path param to "NPM Publish package" Support nested directories in "NPM Publish package" Jan 22, 2025
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you!

@arkadiuszbachorski arkadiuszbachorski merged commit 608f043 into main Jan 23, 2025
4 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/add-cache-dependency-path branch January 23, 2025 17:12
pauljohanneskraft added a commit to StanfordBDHG/ENGAGE-HF-Firebase that referenced this pull request Jan 27, 2025
# Use `npm-publish-package` action

## ♻️ Current situation & Problem
Currently, `publishPackage` is implemented manually. It can reuse
`npm-publish-package` action.


## ⚙️ Release Notes 
* Use npm-publish-package action


## ✅ Testing
⚠️ Do not merge this until
StanfordBDHG/.github#98 is merged and deployed.


### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).

---------

Co-authored-by: Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants