-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minId overloads #2842
base: main
Are you sure you want to change the base?
add minId overloads #2842
Conversation
7d21bd7
to
b1b0d29
Compare
clarify doc comment i now think the XTRIM documentation is saying that an entry at exactly MINID is kept. https://redis.io/docs/latest/commands/xtrim/
I can't tell what's wrong in the appveyor build. It says zero tests failed, but still errors. |
I wasn't able to get dev containers running. The dockerfile in .devcontainer refers to a Dockerfile in I was able to run the tests with only one failure: I got that far by cloning the project in wsl2, running |
I was wrong about appveyor having no test failures. There were 3 failures that don't seem to be related to my changes here. All 3 timed out running more than 5000ms. If there are known test issues, let me know. |
I tried pushing an empty commit to rebuild appveyor. The error moved.
Now there's just that one. |
Fixes #1718
Initial commit. Still orienting on how to contribute.
It's building. Tests pass.
Before I continue, does the diff look sane?
I think I got the "public api" situated correctly.
The strangest thing I ran into was this error about default parameters. I'm not sure if this is pushing me towards adding a new method rather than an overload, e.g. StreamTrimWithMinId. I took out the default CommandFlags to build successfully.
error RS0026: Symbol 'StreamTrim' violates the backcompat requirement: 'Do not add multiple overloads with optional parameters'
I'm having trouble running the tests locally. I tried running the tests before making any changes and ~2/3 passed. It might be because I don't have all the versions of .net installed.