Load templates as memmap rather than in memory #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok I can confirm that generating the templates now works while using a lot less RAM Tomorrow I'll check whether there is a conversion to memory while generating the recording |
|
I need to test this last commit, |
alejoe91
approved these changes
Feb 20, 2024
|
Looks good to me! Let me know when I should merge |
Because they can be very heavy
Don't load in memory. Write over memmap instead
alejoe91
reviewed
Apr 6, 2024
alejoe91
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating very big dataset, it's very easy to have templates bigger than 60 GiB
This PR makes the templates be loaded as memmaps rather than in memory .