pollTimeout : Set pollTimeout during client creation #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Crim are the test failures due to DB not having the new column for pollTimeout ? |
|
Yea, I think you'd need to create a migration like are defined here: https://github.com/SourceLabOrg/kafka-webview/tree/master/kafka-webview-ui/src/main/resources/schema/migration/h2 |
add poll_timeout_ms to view table
Thanks @Crim . Sent in the update view table sql and I see tests are successful now, please review |
|
At first glance this seems good. I'll try to spend some time today to go thru it more closely and get it merged in, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the Fix for #216