Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support SQ 25.1 #662

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add support SQ 25.1 #662

merged 1 commit into from
Jan 29, 2025

Conversation

theshadowco
Copy link
Contributor

Hello there. communitybsl 1.15.2 is out.

SonarCloud project: https://sonarcloud.io/project/overview?id=1c-syntax_sonar-bsl-plugin-community

@ganncamp, Hi!

Please, help me specify the versions correctly:
We need it so that version 1.15.1 is used BEFORE 25.1, and 1.15.2 on any, from 9.9 to the latest.

Thank you.

@ganncamp
Copy link
Collaborator

I don't understand. Chronologically, 9.9 is before 25.1.

@nixel2007
Copy link
Contributor

The question is about sq ranges in the yaml file. Let me provide some context.

Plugin contains our spring boot application inside. Before SQ 25.1 we invoked "run" on special class marked as spring boot application, and everything worked fined.
Spring version was upgraded in SonarQube between 24.12 and 25.1 and our approach is not working anymore.

New version of plugin (1.15.2) contains a workaround for this issue, we do not depend on spring boot application anymore. So plugin version 1.15.2 works well on SQ any version in range 9.9-LATEST (INCLUDING 25.1).
What we want to achieve is limiting version 1.15.1 to [9.9, 24.12], so users who run SQ prior to 25.1 will be able to upgrade communitybsl plugin to 1.15.2 via Marketplace first, and then do an upgrade to SQ 25.1 (or newer) .

So Valeriy asks if he made changes in the yaml file in a correct way. Hope it helps.

@ganncamp
Copy link
Collaborator

Are you saying you don't want any new users to install 1.15.1? If so, then you accomplish that by archiving it.

Copy link
Collaborator

@ganncamp ganncamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but I won't merge it until I get confirmation that this is what you want:

  • hide 1.15.1 from new users
  • publish 1.15.2 to all new users
  • make 1.15.2 available to existing users for upgrade

@nixel2007
Copy link
Contributor

nixel2007 commented Jan 28, 2025

hide 1.15.1 from new users
publish 1.15.2 to all new users
make 1.15.2 available to existing users for upgrade

^ seems correct. Is current setup in yaml correct for this?
Since one can't install previous version of the plugin from marketplace, archiving of 1.15.1 should solve the main issue. however AFAIR this yaml file is used for compatibility matrix as well, and we would like to highlight that versions prior to 1.15.2 are not compatible with SQ 25.1

@ganncamp
Copy link
Collaborator

would like to highlight that versions prior to 1.15.2 are not compatible with SQ 25.1

There's no real "highlight" available. Just publishing. I'm going to merge this and run the job. Come back to me (with a new PR?) if what comes out doesn't look right to you

@ganncamp ganncamp merged commit 07e515f into SonarSource:master Jan 29, 2025
2 checks passed
@nixel2007
Copy link
Contributor

Thanks, Ann!

@theshadowco theshadowco deleted the patch-8 branch January 30, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants