Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCANJLIB-250 Preserve stderr/stdout when the command fails early #222

Merged
merged 2 commits into from
Jan 10, 2025
Merged

SCANJLIB-250 Preserve stderr/stdout when the command fails early #222

merged 2 commits into from
Jan 10, 2025

Conversation

henryju
Copy link
Member

@henryju henryju commented Jan 9, 2025 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Preserve stderr/stdout when the command fails early SCANJLIB-250 Preserve stderr/stdout when the command fails early Jan 9, 2025
@henryju henryju force-pushed the jh/preserve_stderr_when_command_fails_early branch from 789a4a0 to fe2c657 Compare January 9, 2025 16:58
antoine-vinot-sonarsource
antoine-vinot-sonarsource approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@antoine-vinot-sonarsource antoine-vinot-sonarsource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested with my changes from SCANJLI-246:
Capture

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@antoine-vinot-sonarsource antoine-vinot-sonarsource merged commit bbfbc75 into master Jan 10, 2025
7 checks passed
@antoine-vinot-sonarsource antoine-vinot-sonarsource deleted the jh/preserve_stderr_when_command_fails_early branch January 10, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoine-vinot-sonarsource antoine-vinot-sonarsource antoine-vinot-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryju @antoine-vinot-sonarsource