SyntaxNodeExtensions: increase GetBody coverage #8639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
requested changes
Jan 30, 2024
analyzers/tests/SonarAnalyzer.Test/Extensions/SyntaxNodeExtensionsTest.cs
Show resolved
Hide resolved
martin-strecker-sonarsource
requested changes
Jan 30, 2024
analyzers/tests/SonarAnalyzer.Test/Extensions/SyntaxNodeExtensionsTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Extensions/SyntaxNodeExtensionsTest.cs
Outdated
Show resolved
Hide resolved
martin-strecker-sonarsource
requested changes
Jan 30, 2024
| public void GetBody_PropertyDeclaration_SingleAccessor() | ||
| { | ||
| var code = "class AClass { int AProperty { get => 42; } }"; | ||
| ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<PropertyDeclarationSyntax>()).Should().BeNull(); |
There was a problem hiding this comment.
ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<T> is repeated very often. Extract a helper
BlockSyntax ParseForBlockSyntax<T>(string code) where T: CSharpSyntaxNode
=> ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<T>());
|
|
pavel-mikula-sonarsource
added
Type: Tooling
Corniel
reviewed
Mar 26, 2024
| @@ -230,7 +281,7 @@ public void CreateCfg_FieldInitializerWithoutOperation_ReturnsCfg_CS() | |||
| const string code = """ | |||
| public class Sample | |||
| { | |||
| private string field = null!; // null! itself doens't have operation, and we can still generate CFG for it from the equals clause | |||
| private string field = null!; // null! itself doesn't have operation, and we can still generate CFG for it from the equals clause | |||
pavel-mikula-sonarsource
added
Type: Tests
martin-strecker-sonarsource
assigned martin-strecker-sonarsource and unassigned antonioaversa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover
SyntaxNodeExtensions.GetBody, introduced in #8584 but not covered.