Add the possibility of to save the data with hostpath. #605
Conversation
|
Hi @jbazp. Thank you for your contribution. It looks like a cool improvement. Could you please rebase your branch against the current master and provide a testing EDIT: when adding your testing Can you also replicate this to the |
|
Hi @davividal! I made the changes you requested me, Can you check again? |
There was a problem hiding this comment.
How did you generate both tests/unit-compatibility-test/fixtures/sonarqube-dce/host-path-values.yaml and tests/unit-compatibility-test/fixtures/sonarqube/host-path-values.yaml?
They look like a copy of tests/dynamic-compatibility-test/sonarqube-dce/all-values.yaml and tests/dynamic-compatibility-test/sonarqube/all-values.yaml.
Did you run the .cirrus/generate_helm_fixtures.sh script?
charts/sonarqube-dce/CHANGELOG.md
Outdated
| @@ -1,6 +1,9 @@ | |||
| # SonarQube Chart Changelog | |||
| All changes to this chart will be documented in this file. | |||
|
|
|||
| ## [2025.1.1] | |||
| * Add the possibility of to save the data with hostpath. | |||
There was a problem hiding this comment.
This must be under the 2025.1.0 version.
charts/sonarqube-dce/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: sonarqube-dce | |||
| description: SonarQube is a self-managed, automatic code review tool that systematically helps you deliver clean code. As a core element of our Sonar solution, SonarQube integrates into your existing workflow and detects issues in your code to help you perform continuous code inspections of your projects. The tool analyses 30+ different programming languages and integrates into your CI pipeline and DevOps platform to ensure that your code meets high-quality standards. | |||
| type: application | |||
| version: 2025.1.0 | |||
| version: 2025.1.1 | |||
There was a problem hiding this comment.
This must remain as 2025.1.0.
|
Yes! First, I created the values.yaml files:
And finally, I ran .cirrus/generate_helm_fixtures.sh locally and it genereted me the following files:
|
|
Hi @davividal! Do you need anything else? |
|
@jbazp can you rebase from master, please? |
# Conflicts: # charts/sonarqube-dce/CHANGELOG.md # charts/sonarqube/CHANGELOG.md
|
@davividal I did the rebase. |
# Conflicts: # charts/sonarqube-dce/CHANGELOG.md
|
Hi @davividal ! Can you merge the PR? Otherwise I have to do rebase constantly. |
Sonarqube will not have more than one instance at a time, I want it to always run on a node and within that node save the information with hostpath, I do not want PVC or PV, I want to directly access the host disk to save it and it will go very quickly , easy and without intermediaries (Storage Provider).
Please ensure your pull request adheres to the following guidelines:
CHANGELOG.mdfile of the respected chart as well as theChart.yaml