Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD-5391 setup pre commit validation at pr level #29

Merged
merged 9 commits into from
Jun 20, 2024
Merged

BUILD-5391 setup pre commit validation at pr level #29

merged 9 commits into from
Jun 20, 2024

Conversation

sebastienvermeille
Copy link
Contributor

@sebastienvermeille sebastienvermeille commented Jun 19, 2024 •
edited
Loading

BUILD-5391 setup pre commit validation at pr level

Changes

  • Enable pre-commit validation at PR level
  • Update pre-commit-config so that it verify also github action and workflows (provides valuable inputs!)
  • Fix issues so that any new contributor as of today do not have to fix earlier issues.

@sebastienvermeille sebastienvermeille self-assigned this Jun 19, 2024
@sebastienvermeille sebastienvermeille added the enhancement New feature or request label Jun 19, 2024
@sebastienvermeille sebastienvermeille marked this pull request as ready for review June 19, 2024 12:00
@sebastienvermeille sebastienvermeille force-pushed the feat/svermeille/BUILD-5391-setup-pre-commit-validation-at-pr-level branch 3 times, most recently from 266a953 to ccd0ba2 Compare June 19, 2024 13:06
@sebastienvermeille sebastienvermeille force-pushed the feat/svermeille/BUILD-5391-setup-pre-commit-validation-at-pr-level branch from bd7da8e to 8f5968b Compare June 19, 2024 13:11
julien-carsique-sonarsource
julien-carsique-sonarsource reviewed Jun 19, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sebastienvermeille sebastienvermeille merged commit 9661adf into master Jun 20, 2024
8 checks passed
@sebastienvermeille sebastienvermeille deleted the feat/svermeille/BUILD-5391-setup-pre-commit-validation-at-pr-level branch June 20, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-carsique-sonarsource julien-carsique-sonarsource julien-carsique-sonarsource approved these changes

Assignees

@sebastienvermeille sebastienvermeille

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastienvermeille @julien-carsique-sonarsource