Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECHOES-292 Add new Inline Message and Callout components #231

Merged
merged 1 commit into from
Jan 3, 2025
Merged

ECHOES-292 Add new Inline Message and Callout components #231

merged 1 commit into from
Jan 3, 2025

Conversation

jeremy-davis-sonarsource
Copy link
Contributor

@jeremy-davis-sonarsource jeremy-davis-sonarsource commented Dec 24, 2024 •
edited by jira bot
Loading

@netlify Netlify
Copy link

netlify bot commented Dec 24, 2024 •
edited
Loading

✅ Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 38e58fc
🔍 Latest deploy log https://app.netlify.com/sites/echoes-react/deploys/6776be774346930008190ac5
😎 Deploy Preview https://deploy-preview-231--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeremy-davis-sonarsource jeremy-davis-sonarsource force-pushed the jay/flag-messages branch 2 times, most recently from dc02126 to 13a01d6 Compare December 27, 2024 13:55
@gregaubert gregaubert self-requested a review December 30, 2024 14:25
gregaubert
gregaubert reviewed Dec 30, 2024
View reviewed changes
src/components/index.ts Outdated Show resolved Hide resolved
src/components/message/MessageStyles.tsx Outdated Show resolved Hide resolved
src/components/message/MessageInline.tsx Outdated Show resolved Hide resolved
src/components/message/MessageInline.tsx Outdated Show resolved Hide resolved
src/components/message/MessageStyles.tsx Outdated Show resolved Hide resolved
src/components/message/MessageStyles.tsx Outdated Show resolved Hide resolved
src/components/message/MessageStyles.tsx Outdated Show resolved Hide resolved
src/components/message/MessageCallout.tsx Outdated Show resolved Hide resolved
src/components/message/MessageStyles.tsx Outdated Show resolved Hide resolved
src/components/message/MessageTypes.tsx Outdated Show resolved Hide resolved
@jeremy-davis-sonarsource jeremy-davis-sonarsource force-pushed the jay/flag-messages branch 4 times, most recently from ebfa955 to 2ec6207 Compare January 2, 2025 14:20
@jeremy-davis-sonarsource jeremy-davis-sonarsource marked this pull request as ready for review January 2, 2025 14:23
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 2, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

gregaubert
gregaubert approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@gregaubert gregaubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :)

src/components/messages/MessageScreenReaderPrefix.tsx Show resolved Hide resolved
@jeremy-davis-sonarsource jeremy-davis-sonarsource merged commit 0b78242 into main Jan 3, 2025
9 checks passed
@jeremy-davis-sonarsource jeremy-davis-sonarsource deleted the jay/flag-messages branch January 3, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregaubert gregaubert gregaubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremy-davis-sonarsource @gregaubert