Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix force_store_pdf_enabled, improve logging and clean things #789

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

anxodio
Copy link
Contributor

@anxodio anxodio commented Jan 9, 2025

Arregla el codi perque es pugui forcar desde context l'activació o desactivació del PDF storer (arreglant nomenclatura), i millora els logs :)

Copy link

github-actions bot commented Jan 9, 2025

Test Results

  3 files  + 1    3 suites  +1   8s ⏱️ - 1m 13s
160 tests +37  159 ✅ +55  1 💤 ±0  0 ❌  - 1 
163 runs  +40  162 ✅ +58  1 💤 ±0  0 ❌  - 1 

Results for commit ef111fe. ± Comparison against base commit 5b8c077.

This pull request removes 56 and adds 93 tests. Note that renamed tests count towards both.
destral.testing.OOBaseTests ‑ test_access_rules
destral.testing.OOBaseTests ‑ test_all_views
destral.testing.OOBaseTests ‑ test_translate_modules
som_switching.tests.tests_activaciones.TestsAutoActiva ‑ test_import_r105_01_tancar_cac_al_finalitzar_r1
som_switching.tests.tests_activaciones.TestsAutoActiva ‑ test_se_cierra_caso_cac_activacion_automatica_009_open
som_switching.tests.tests_activaciones.TestsAutoActiva ‑ test_se_cierra_caso_cac_activacion_automatica_009_pending
som_switching.tests.tests_activacions_b1.TestActivacioB1 ‑ test_b1_05_baixa_mailchimp_error__active_contract
som_switching.tests.tests_activacions_b1.TestActivacioB1 ‑ test_b1_05_baixa_mailchimp_error__more_than_one_contract
som_switching.tests.tests_activacions_b1.TestActivacioB1 ‑ test_b1_05_baixa_mailchimp_ok
som_switching.tests.tests_activacions_b2.TestActivacioB2 ‑ test_b2_05_baixa_mailchimp_error__active_contract
…
eport_tester.tests.test_report_test.TestReportTest.test___get_resource_id___i ‑ report_tester.tests.test_report_test.TestReportTest.test___get_resource_id___id
eport_tester.tests.test_report_test.TestReportTest.test__accept_one_test__no_file ‑ report_tester.tests.test_report_test.TestReportTest.test__accept_one_test__no_files
eport_tester.tests.test_report_test.TestReportTest.test__accept_one_test__no_resul ‑ report_tester.tests.test_report_test.TestReportTest.test__accept_one_test__no_result
eport_tester.tests.test_report_test.TestReportTest.test__accept_one_test__o ‑ report_tester.tests.test_report_test.TestReportTest.test__accept_one_test__ok
eport_tester.tests.test_report_test.TestReportTest.test__execute_one_test__diferent ‑ report_tester.tests.test_report_test.TestReportTest.test__execute_one_test__diferents
eport_tester.tests.test_report_test.TestReportTest.test__execute_one_test__equal ‑ report_tester.tests.test_report_test.TestReportTest.test__execute_one_test__equals
eport_tester.tests.test_report_test.TestReportTest.test__execute_one_test__error_on_pd ‑ report_tester.tests.test_report_test.TestReportTest.test__execute_one_test__error_on_pdf
eport_tester.tests.test_report_test.TestReportTest.test__execute_one_test__pdf_ok_noexpecte ‑ report_tester.tests.test_report_test.TestReportTest.test__execute_one_test__pdf_ok_noexpected
eport_tester.tests.test_report_test.TestReportTest.test__files__some_operation ‑ report_tester.tests.test_report_test.TestReportTest.test__files__some_operations
estral.testing.OOBaseTests.test_access_rule ‑ destral.testing.OOBaseTests.test_access_rules
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
som_switching.tests.tests_wizard_validate_d101.TestWizardValidateD101 ‑ test__create_case_m1_01_motiu_06__S_R
iscedata_facturacio_comer_som.tests.tests_FacturacioFacturaReport_some.Tests_FacturacioFacturaReport_logo_component.test__som_report_comp_logo__energetica_moc ‑ giscedata_facturacio_comer_som.tests.tests_FacturacioFacturaReport_some.Tests_FacturacioFacturaReport_logo_component.test__som_report_comp_logo__energetica_mock

♻️ This comment has been updated with latest results.

@anxodio anxodio force-pushed the fix_force_store_pdf_enabled branch from 3f1bb8e to 51eed22 Compare January 13, 2025 14:01
@@ -110,7 +110,7 @@ jobs:
- name: Install dependencies
run: |
sudo apt-get --allow-releaseinfo-change update
sudo apt-get install python2-dev python3-dev libxml2-dev libxmlsec1 libxmlsec1-dev libgdal-dev -y
sudo apt-get install python2-dev python3-dev libxml2-dev libxmlsec1 libxmlsec1-dev libgdal-dev pdftk -y
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessari per el test que prova el join, sense aquest paquet la llibreria pypdftk no funciona!

@pauboixsom pauboixsom merged commit 8c61cae into main Jan 14, 2025
6 checks passed
@pauboixsom pauboixsom deleted the fix_force_store_pdf_enabled branch January 14, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants