Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): fix headers of exports #3621

Closed
wants to merge 1 commit into from
Closed

fix(backend): fix headers of exports #3621

wants to merge 1 commit into from

Conversation

pYassine
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.56%. Comparing base (b1f2df1) to head (a21d739).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...controllers/export-structure-usagers.controller.ts 90.90% 1 Missing ⚠️
...es/backend/src/usagers/services/usagers.service.ts 85.71% 1 Missing ⚠️
...xlsx-structure-usagers-renderer/applyDateFormat.ts 90.00% 1 Missing ⚠️
...kages/backend/src/util/phone/phoneUtils.service.ts 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
+ Coverage   66.44%   66.56%   +0.11%     
==========================================
  Files         913      913              
  Lines       15043    15051       +8     
  Branches     2080     2078       -2     
==========================================
+ Hits         9996    10018      +22     
+ Misses       4734     4721      -13     
+ Partials      313      312       -1     
Files with missing lines Coverage Δ
...kend/src/usagers/controllers/usagers.controller.ts 51.00% <100.00%> (+0.33%) ⬆️
.../services/xlsx-structure-usagers-renderer/index.ts 100.00% <100.00%> (ø)
...ure-usagers-renderer/renderStructureUsagersRows.ts 97.77% <100.00%> (+0.27%) ⬆️
...usagers-renderer/tests/FIRST_SHEET_USAGERS.mock.ts 100.00% <ø> (ø)
...controllers/export-structure-usagers.controller.ts 93.87% <90.90%> (-1.37%) ⬇️
...es/backend/src/usagers/services/usagers.service.ts 39.39% <85.71%> (+2.83%) ⬆️
...xlsx-structure-usagers-renderer/applyDateFormat.ts 90.00% <90.00%> (ø)
...kages/backend/src/util/phone/phoneUtils.service.ts 70.96% <66.66%> (-1.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f2df1...a21d739. Read the comment docs.

@pYassine pYassine marked this pull request as ready for review January 16, 2025 09:07
@pYassine pYassine closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants