Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): fix export headers #3619

Closed
wants to merge 1 commit into from
Closed

Conversation

pYassine
Copy link
Contributor

No description provided.

@tokenbureau
Copy link

tokenbureau bot commented Jan 16, 2025

🎉 Deployment for commit dd2fb13 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-dd2fb136a4acd29c144d569466cfcc8427f2d42f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-dd2fb136a4acd29c144d569466cfcc8427f2d42f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-dd2fb136a4acd29c144d569466cfcc8427f2d42f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-dd2fb136a4acd29c144d569466cfcc8427f2d42f
Debug

@pYassine pYassine marked this pull request as ready for review January 16, 2025 01:03
@pYassine pYassine force-pushed the feat-search-by-phone branch from 63f7922 to 3712e8c Compare January 16, 2025 01:09
@pYassine pYassine closed this Jan 16, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.56%. Comparing base (b1f2df1) to head (a433c5f).

Files with missing lines Patch % Lines
...controllers/export-structure-usagers.controller.ts 90.90% 1 Missing ⚠️
...es/backend/src/usagers/services/usagers.service.ts 85.71% 1 Missing ⚠️
...xlsx-structure-usagers-renderer/applyDateFormat.ts 90.00% 1 Missing ⚠️
...kages/backend/src/util/phone/phoneUtils.service.ts 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3619      +/-   ##
==========================================
+ Coverage   66.44%   66.56%   +0.11%     
==========================================
  Files         913      913              
  Lines       15043    15051       +8     
  Branches     2080     2082       +2     
==========================================
+ Hits         9996    10018      +22     
- Misses       4734     4853     +119     
+ Partials      313      180     -133     
Files with missing lines Coverage Δ
...kend/src/usagers/controllers/usagers.controller.ts 51.00% <100.00%> (+0.33%) ⬆️
.../services/xlsx-structure-usagers-renderer/index.ts 100.00% <100.00%> (ø)
...ure-usagers-renderer/renderStructureUsagersRows.ts 97.77% <100.00%> (+0.27%) ⬆️
...usagers-renderer/tests/FIRST_SHEET_USAGERS.mock.ts 100.00% <ø> (ø)
...controllers/export-structure-usagers.controller.ts 93.87% <90.90%> (-1.37%) ⬇️
...es/backend/src/usagers/services/usagers.service.ts 39.39% <85.71%> (+2.83%) ⬆️
...xlsx-structure-usagers-renderer/applyDateFormat.ts 90.00% <90.00%> (ø)
...kages/backend/src/util/phone/phoneUtils.service.ts 70.96% <66.66%> (-1.45%) ⬇️

... and 58 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f2df1...a433c5f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants