Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix select boxes #3575

Merged
merged 3 commits into from
Nov 27, 2024
Merged

fix(frontend): fix select boxes #3575

merged 3 commits into from
Nov 27, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review November 26, 2024 11:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.24299% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (b697eab) to head (58ee490).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...nage-usagers-page/manage-usagers-page.component.ts 0.00% 6 Missing ⚠️
...lter/services/usagersSearchStringFilter.service.ts 53.84% 5 Missing and 1 partial ⚠️
...kend/src/usagers/controllers/usagers.controller.ts 20.00% 4 Missing ⚠️
.../src/_migrations/1731349672897-manual-migration.ts 33.33% 2 Missing ⚠️
...tabase/entities/usager/UsagerSubscriber.typeorm.ts 95.45% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3575      +/-   ##
==========================================
- Coverage   66.68%   66.68%   -0.01%     
==========================================
  Files         917      919       +2     
  Lines       15085    15048      -37     
  Branches     2130     2116      -14     
==========================================
- Hits        10060    10035      -25     
+ Misses       4986     4709     -277     
- Partials       39      304     +265     
Files with missing lines Coverage Δ
...ckend/src/_common/decorators/StripTagsDecorator.ts 100.00% <100.00%> (ø)
...ies/contact-support/ContactSupportTable.typeorm.ts 100.00% <100.00%> (+11.76%) ⬆️
.../entities/structure/StructureSubscriber.typeorm.ts 100.00% <100.00%> (ø)
...abase/entities/structure/StructureTable.typeorm.ts 90.90% <100.00%> (-1.10%) ⬇️
...rc/database/entities/usager/UsagerTable.typeorm.ts 100.00% <ø> (ø)
.../user-structure/UserStructureSubscriber.typeorm.ts 100.00% <100.00%> (ø)
...ities/user-structure/UserStructureTable.typeorm.ts 100.00% <ø> (ø)
...ase/services/_postgres/PG_CONNECT_OPTIONS.const.ts 52.17% <ø> (ø)
...ackages/backend/src/usagers/dto/create-note.dto.ts 100.00% <100.00%> (ø)
...kages/backend/src/usagers/dto/search-usager.dto.ts 100.00% <ø> (ø)
... and 16 more

... and 115 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b697eab...58ee490. Read the comment docs.

Copy link

🎉 Deployment for commit 58ee490 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-58ee4907fda45ad7dea105f16f3f7cc281904505
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-58ee4907fda45ad7dea105f16f3f7cc281904505
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-58ee4907fda45ad7dea105f16f3f7cc281904505
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-58ee4907fda45ad7dea105f16f3f7cc281904505
Debug

@pYassine pYassine merged commit b4d3de9 into master Nov 27, 2024
12 checks passed
@pYassine pYassine deleted the feat-add-select-multiple branch November 27, 2024 09:08
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.185.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants