Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactions): update lastinteraction date #3137

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

pYassine
Copy link
Contributor

@pYassine pYassine commented Jan 2, 2024

No description provided.

Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 2, 2024

🎉 Deployment for commit 471fc79 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-471fc79ff2ee0688d7e6da9c2cd724a9e2682339
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-471fc79ff2ee0688d7e6da9c2cd724a9e2682339
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-471fc79ff2ee0688d7e6da9c2cd724a9e2682339
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-471fc79ff2ee0688d7e6da9c2cd724a9e2682339
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (1aceb1a) 67.66% compared to head (471fc79) 67.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3137      +/-   ##
==========================================
- Coverage   67.66%   67.51%   -0.15%     
==========================================
  Files         915      917       +2     
  Lines       14750    14800      +50     
  Branches     2129     2130       +1     
==========================================
+ Hits         9980     9992      +12     
- Misses       4493     4530      +37     
- Partials      277      278       +1     
Files Coverage Δ
...actions/services/getLastInteractionDate.service.ts 82.35% <100.00%> (+5.21%) ⬆️
...rations/1703676787762-update-migrated-migration.ts 42.85% <42.85%> (ø)
...ns/1703676787763-fix-last-interaction-migration.ts 18.18% <18.18%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aceb1a...471fc79. Read the comment docs.

@pYassine pYassine merged commit c8ad798 into master Jan 2, 2024
16 checks passed
@pYassine pYassine deleted the fix-last-interaction branch January 2, 2024 15:20
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.153.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants