Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat delete useless data stats #3125

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Conversation

pYassine
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pYassine pYassine force-pushed the feat-delete-useless-data-stats branch from 5f21fa9 to da4d678 Compare December 26, 2023 18:07
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (a639580) 67.76% compared to head (5065cc9) 67.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
- Coverage   67.76%   67.66%   -0.11%     
==========================================
  Files         911      915       +4     
  Lines       14660    14750      +90     
  Branches     2112     2129      +17     
==========================================
+ Hits         9934     9980      +46     
- Misses       4451     4493      +42     
- Partials      275      277       +2     
Files Coverage Δ
...s/_init-db/1603812391580-pr-env-create-database.ts 21.05% <ø> (ø)
...in-structures/services/admin-structures.service.ts 98.48% <ø> (ø)
...base/entities/usager/UsagerHistoryTable.typeorm.ts 100.00% <100.00%> (ø)
...ervices/_scripts/data-anonymizer/dataAnonymizer.ts 33.33% <ø> (-0.96%) ⬇️
...tabase/services/usager/usagerRepository.service.ts 92.15% <100.00%> (+0.49%) ⬆️
...d/src/stats/controllers/stats.public.controller.ts 100.00% <100.00%> (+2.77%) ⬆️
packages/backend/src/stats/stats.module.ts 100.00% <100.00%> (ø)
...kend/src/usagers/controllers/usagers.controller.ts 55.03% <ø> (ø)
...rc/usagers/services/dataCleanerForStats.service.ts 100.00% <100.00%> (ø)
packages/backend/src/usagers/services/index.ts 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a639580...5065cc9. Read the comment docs.

@pYassine pYassine force-pushed the feat-delete-useless-data-stats branch from 8a1c491 to 5065cc9 Compare December 27, 2023 11:32
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

18 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

🎉 Deployment for commit 5065cc9 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-5065cc9d7f1011380d63dae647d7385b984ad5bb
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-5065cc9d7f1011380d63dae647d7385b984ad5bb
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-5065cc9d7f1011380d63dae647d7385b984ad5bb
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-5065cc9d7f1011380d63dae647d7385b984ad5bb
Debug

@pYassine pYassine merged commit 2e4f686 into master Dec 28, 2023
16 checks passed
@pYassine pYassine deleted the feat-delete-useless-data-stats branch December 28, 2023 09:42
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.153.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants