Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add mail open data #3104

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Feat add mail open data #3104

merged 3 commits into from
Dec 17, 2023

Conversation

pYassine
Copy link
Contributor

No description provided.

Copy link

🎉 Deployment for commit 4884c56 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-4884c5677f8916961d568e518f9f71220d5727b0
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-4884c5677f8916961d568e518f9f71220d5727b0
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-4884c5677f8916961d568e518f9f71220d5727b0
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-4884c5677f8916961d568e518f9f71220d5727b0
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Merging #3104 (4884c56) into master (cfb975a) will increase coverage by 0.13%.
Report is 5 commits behind head on master.
The diff coverage is 78.94%.

❗ Current head 4884c56 differs from pull request most recent head 7910580. Consider uploading reports for the commit 7910580 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
+ Coverage   67.74%   67.87%   +0.13%     
==========================================
  Files         919      915       -4     
  Lines       14692    14647      -45     
  Branches     2113     2105       -8     
==========================================
- Hits         9953     9942      -11     
+ Misses       4464     4432      -32     
+ Partials      275      273       -2     
Files Coverage Δ
...ties/open-data-place/OpenDataPlaceTable.typeorm.ts 100.00% <100.00%> (ø)
...ges/backend/src/open-data-places/load-soliguide.ts 0.00% <ø> (ø)
...frontend/src/_common/mocks/STRUCTURE_MOCK.const.ts 100.00% <100.00%> (ø)
...es/frontend/src/_common/mocks/USAGER_ACTIF.mock.ts 100.00% <100.00%> (ø)
...es/frontend/src/_common/mocks/USAGER_REFUS.mock.ts 100.00% <100.00%> (ø)
.../frontend/src/_common/mocks/USER_STRUCTURE.mock.ts 100.00% <100.00%> (ø)
...ntend/src/_common/model/telephone/COUNTRY_CODES.ts 100.00% <100.00%> (ø)
.../app/modules/shared/phone/mobilePhone.validator.ts 70.00% <ø> (ø)
...rontend/src/app/modules/shared/phone/phoneUtils.ts 76.19% <100.00%> (ø)
...ructure-edit-form/structure-edit-form.component.ts 62.68% <ø> (ø)
... and 9 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1037457...7910580. Read the comment docs.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pYassine pYassine merged commit d363b6b into master Dec 17, 2023
10 of 12 checks passed
@pYassine pYassine deleted the feat-add-mail-open-data branch December 17, 2023 15:27
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.149.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants