Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete interaction #3065

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix delete interaction #3065

merged 2 commits into from
Nov 21, 2023

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine force-pushed the fix-delete-interaction branch from 1d1627e to 6c3c196 Compare November 21, 2023 15:24
@pYassine pYassine marked this pull request as ready for review November 21, 2023 15:26
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

🎉 Deployment for commit cbe0c1f :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-cbe0c1f2df366fec7ffd2c3fab795d5b685b0bcc
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-cbe0c1f2df366fec7ffd2c3fab795d5b685b0bcc
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-cbe0c1f2df366fec7ffd2c3fab795d5b685b0bcc
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-cbe0c1f2df366fec7ffd2c3fab795d5b685b0bcc
Debug

@codecov-commenter
Copy link

Codecov Report

Merging #3065 (cbe0c1f) into master (834397b) will decrease coverage by 0.04%.
The diff coverage is 78.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
- Coverage   67.82%   67.78%   -0.04%     
==========================================
  Files         913      913              
  Lines       14657    14625      -32     
  Branches     2119     2104      -15     
==========================================
- Hits         9941     9914      -27     
+ Misses       4444     4439       -5     
  Partials      272      272              
Files Coverage Δ
...vices/interaction/interactionRepository.service.ts 90.00% <100.00%> (+2.69%) ⬆️
...ackend/src/interactions/interactions.controller.ts 62.16% <ø> (ø)
...teractions/services/interactionsCreator.service.ts 100.00% <100.00%> (+11.32%) ⬆️
...urriers/profil-historique-courriers.component.html 100.00% <ø> (ø)
...teractions/services/InteractionsDeletor.service.ts 76.47% <64.28%> (-13.19%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834397b...cbe0c1f. Read the comment docs.

@pYassine pYassine merged commit 73626e2 into master Nov 21, 2023
17 checks passed
@pYassine pYassine deleted the fix-delete-interaction branch November 21, 2023 22:18
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.144.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants