Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(history): add sorting in tables #3023

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

pYassine
Copy link
Contributor

@pYassine pYassine commented Nov 1, 2023

No description provided.

@pYassine pYassine marked this pull request as ready for review November 1, 2023 23:40
@pYassine pYassine force-pushed the feat-interactions-pagination branch from a4b84e6 to 489c91f Compare November 1, 2023 23:40
Copy link

github-actions bot commented Nov 2, 2023

🎉 Deployment for commit 06532be :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-06532be08a1abc75ab5511f330e01b7d3d752431
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-06532be08a1abc75ab5511f330e01b7d3d752431
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-06532be08a1abc75ab5511f330e01b7d3d752431
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-06532be08a1abc75ab5511f330e01b7d3d752431
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #3023 (06532be) into feat-history-tabs (469cb12) will decrease coverage by 0.11%.
The diff coverage is 42.62%.

❗ Current head 06532be differs from pull request most recent head 2489037. Consider uploading reports for the commit 2489037 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           feat-history-tabs    #3023      +/-   ##
=====================================================
- Coverage              68.01%   67.91%   -0.11%     
=====================================================
  Files                    919      917       -2     
  Lines                  14675    14669       -6     
  Branches                2128     2115      -13     
=====================================================
- Hits                    9981     9962      -19     
- Misses                  4421     4436      +15     
+ Partials                 273      271       -2     
Files Coverage Δ
..._common/model/interaction/INTERACTIONS_OK.const.ts 100.00% <100.00%> (ø)
...s/_init-db/1603812391580-pr-env-create-database.ts 21.05% <ø> (ø)
...in-structures/services/admin-structures.service.ts 98.52% <ø> (ø)
.../entities/interaction/InteractionsTable.typeorm.ts 100.00% <ø> (ø)
...rc/database/entities/usager/UsagerTable.typeorm.ts 100.00% <ø> (ø)
...ipts/data-anonymizer/dataInteractionsAnonymizer.ts 62.50% <ø> (ø)
packages/backend/src/interactions/dto/index.ts 100.00% <ø> (ø)
...ractions/interactions.controller.security-tests.ts 100.00% <ø> (ø)
...teractions/services/interactionsCreator.service.ts 90.00% <100.00%> (ø)
...QuestionsInPeriodInteractionsRepository.service.ts 100.00% <ø> (ø)
... and 28 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469cb12...2489037. Read the comment docs.

@pYassine pYassine merged commit 033291a into feat-history-tabs Nov 6, 2023
5 of 6 checks passed
@pYassine pYassine deleted the feat-interactions-pagination branch November 6, 2023 15:44
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants