Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(history): create a new history page #3022

Merged
merged 11 commits into from
Nov 6, 2023
Merged

feat(history): create a new history page #3022

merged 11 commits into from
Nov 6, 2023

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine temporarily deployed to review-auto October 31, 2023 15:01 — with GitHub Actions Inactive
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pYassine pYassine temporarily deployed to review-auto October 31, 2023 16:05 — with GitHub Actions Inactive
@pYassine pYassine marked this pull request as ready for review October 31, 2023 16:11
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #3022 (ca38aea) into master (b378d2d) will decrease coverage by 0.15%.
The diff coverage is 52.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3022      +/-   ##
==========================================
- Coverage   67.99%   67.84%   -0.15%     
==========================================
  Files         912      919       +7     
  Lines       14583    14690     +107     
  Branches     2128     2115      -13     
==========================================
+ Hits         9915     9967      +52     
- Misses       4395     4450      +55     
  Partials      273      273              
Files Coverage Δ
..._common/model/interaction/INTERACTIONS_OK.const.ts 100.00% <100.00%> (ø)
...s/_init-db/1603812391580-pr-env-create-database.ts 21.05% <ø> (ø)
...in-structures/services/admin-structures.service.ts 98.52% <ø> (ø)
.../entities/interaction/InteractionsTable.typeorm.ts 100.00% <ø> (ø)
...rc/database/entities/usager/UsagerTable.typeorm.ts 100.00% <ø> (ø)
...ipts/data-anonymizer/dataInteractionsAnonymizer.ts 62.50% <ø> (ø)
packages/backend/src/interactions/dto/index.ts 100.00% <ø> (ø)
...ractions/interactions.controller.security-tests.ts 100.00% <ø> (ø)
...teractions/services/interactionsCreator.service.ts 89.47% <100.00%> (-0.53%) ⬇️
...QuestionsInPeriodInteractionsRepository.service.ts 100.00% <ø> (ø)
... and 78 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b378d2d...ca38aea. Read the comment docs.

@pYassine pYassine temporarily deployed to review-auto November 1, 2023 19:06 — with GitHub Actions Inactive
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

github-actions bot commented Nov 6, 2023

🎉 Deployment for commit ca38aea :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-ca38aeac4c981506ddc4c6824e4098f8a0177d0f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-ca38aeac4c981506ddc4c6824e4098f8a0177d0f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-ca38aeac4c981506ddc4c6824e4098f8a0177d0f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-ca38aeac4c981506ddc4c6824e4098f8a0177d0f
Debug

@pYassine pYassine merged commit 369d1d4 into master Nov 6, 2023
16 checks passed
@pYassine pYassine deleted the feat-history-tabs branch November 6, 2023 22:03
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.142.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants