Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primary-selection filter #1641

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

notpeelz
Copy link
Contributor

@notpeelz notpeelz commented Jan 22, 2025

I'm working on a PR for niri to disable the primary selection. I've had to make some changes in Smithay in order to support disabling of the primary selection at runtime (live-reloading of the config).

Niri PR: YaLTeR/niri#1011

@kchibisov I was told you were the last person who reworked clipboard handling in Smithay, and that you might want to take a look at these changes.

@kchibisov
Copy link
Member

If the filter is done the same way as any other filter, I'm not sure there's anything needed from my end, since it doesn't touch anything in clipboard handling itself.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 19.34%. Comparing base (953959e) to head (c64e0a7).

Files with missing lines Patch % Lines
src/wayland/selection/primary_selection/mod.rs 75.00% 4 Missing ⚠️
src/wayland/selection/wlr_data_control/mod.rs 20.00% 4 Missing ⚠️
src/wayland/selection/wlr_data_control/device.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
+ Coverage   17.33%   19.34%   +2.00%     
==========================================
  Files         171      171              
  Lines       28389    28401      +12     
==========================================
+ Hits         4922     5493     +571     
+ Misses      23467    22908     -559     
Flag Coverage Δ
wlcs-buffer 16.84% <58.33%> (+0.02%) ⬆️
wlcs-core 16.58% <58.33%> (+0.02%) ⬆️
wlcs-output 6.84% <58.33%> (+0.02%) ⬆️
wlcs-pointer-input 18.31% <58.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notpeelz notpeelz force-pushed the feat-primary-selection-filter branch from c64e0a7 to 545d467 Compare January 22, 2025 22:54
@notpeelz notpeelz force-pushed the feat-primary-selection-filter branch from 545d467 to fa4c362 Compare January 23, 2025 03:02
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Drakulix Drakulix merged commit 7a4c803 into Smithay:master Jan 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants