Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compositor: Fix cursor redraw on scale change #1638

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Jan 17, 2025

So because we are allocating a new buffer for cursor planes, the config.dst of the previous plane state might not actually represent the size of the cursor element, but simply the size of the cursor-plane (or the nearest size hint).

That might stay the same, if the cursor is simply rescaled, resulting in our tests failing to detect, that we need to redraw. This in particular happens with MemoryRenderElements + RescaleRenderElements, where neither the Id nor the commit_counter changes. So we have to remember the element size.

(Or we make src/dst actually use the cursor size, without re-allocating the buffer of course, but I am not sure, if compatibility for that is so great. Generally cursor planes don't seem very capable.)

@Drakulix Drakulix requested a review from cmeissl January 17, 2025 16:57
@Drakulix Drakulix merged commit 953959e into master Jan 17, 2025
13 checks passed
@Drakulix Drakulix deleted the fix/cursor_scale_scanout branch January 17, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants