compositor: Fix cursor redraw on scale change #1638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So because we are allocating a new buffer for cursor planes, the
config.dst
of the previous plane state might not actually represent the size of the cursor element, but simply the size of the cursor-plane (or the nearest size hint).That might stay the same, if the cursor is simply rescaled, resulting in our tests failing to detect, that we need to redraw. This in particular happens with
MemoryRenderElements
+RescaleRenderElements
, where neither theId
nor thecommit_counter
changes. So we have to remember the element size.(Or we make
src
/dst
actually use the cursor size, without re-allocating the buffer of course, but I am not sure, if compatibility for that is so great. Generally cursor planes don't seem very capable.)