Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(script): sepolia deployment #509

Merged
merged 33 commits into from
Aug 14, 2024
Merged

refactor(script): sepolia deployment #509

merged 33 commits into from
Aug 14, 2024

Conversation

samooyo
Copy link
Contributor

@samooyo samooyo commented Aug 9, 2024 •
edited
Loading

This PR aims to refactor all protocol deployment scripts to prioritize using Foundry scripts instead of Bash !

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

Natspec smells of commit 6e29830 during Natspec report foundry-rs/foundry#2220

Warning

Natspec smells has found 8 problems in the code.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

LCOV of commit 6e29830 during Coverage report foundry-rs/foundry#3539

Summary coverage rate:
  lines......: 82.3% (2557 of 3107 lines)
  functions..: 80.8% (620 of 767 functions)
  branches...: 78.5% (527 of 671 branches)

Files changed coverage rate:
                                                                      |Lines       |Functions  |Branches    
  Filename                                                            |Rate     Num|Rate    Num|Rate     Num
  ==========================================================================================================
  script/00_DeployUsdn.s.sol                                          | 0.0%      6| 0.0%     1| 0.0%      4
  script/01_Deploy.s.sol                                              | 0.0%    122| 0.0%    14| 0.0%     36
  script/02_DeployRedstoneMiddleware.s.sol                            | 0.0%     13| 0.0%     2| 0.0%      2
  script/Utils.s.sol                                                  | 0.0%     39| 0.0%     8| 0.0%      2
  src/UsdnProtocol/UsdnProtocolImpl.sol                               | 100%     63| 100%     3| 100%      4
  src/UsdnProtocol/UsdnProtocolSepolia.sol                            |91.7%     12|66.7%     3|50.0%      6
  test/unit/UsdnProtocol/utils/Handler.sol                            |93.7%    126|96.9%    97|25.0%      4
  test/unit/UsdnProtocol/utils/HandlerSepolia.sol                     | 100%      2| 100%     2|    -      0

@samooyo samooyo added To review The pull request need to be reviewed before merge 2 reviews required labels Aug 12, 2024
@samooyo samooyo self-assigned this Aug 12, 2024
@samooyo samooyo marked this pull request as ready for review August 12, 2024 14:50
@KirienzoEth KirienzoEth self-requested a review August 12, 2024 15:18
@beeb beeb self-requested a review August 13, 2024 05:57
@samooyo samooyo removed the To review The pull request need to be reviewed before merge label Aug 13, 2024
beeb
beeb requested changes Aug 13, 2024
View reviewed changes
script/00_DeployUsdn.s.sol Outdated Show resolved Hide resolved
script/deployMainnet.sh Show resolved Hide resolved
script/Utils.s.sol Outdated Show resolved Hide resolved
script/Utils.s.sol Outdated Show resolved Hide resolved
script/Utils.s.sol Outdated Show resolved Hide resolved
script/deployMainnet.sh Outdated Show resolved Hide resolved
script/deployMainnet.sh Outdated Show resolved Hide resolved
script/deployMainnet.sh Show resolved Hide resolved
script/deployMainnet.sh Show resolved Hide resolved
script/deployMainnet.sh Outdated Show resolved Hide resolved
KirienzoEth
KirienzoEth reviewed Aug 13, 2024
View reviewed changes
script/01_Deploy.s.sol Outdated Show resolved Hide resolved
@SmarDex-Ecosystem SmarDex-Ecosystem deleted a comment from beeb Aug 13, 2024
@samooyo samooyo requested a review from beeb August 13, 2024 15:16
@samooyo samooyo added To review The pull request need to be reviewed before merge 2 reviews required labels Aug 13, 2024
beeb
beeb reviewed Aug 14, 2024
View reviewed changes
script/01_Deploy.s.sol Outdated Show resolved Hide resolved
beeb
beeb reviewed Aug 14, 2024
View reviewed changes
script/deployMainnet.sh Outdated Show resolved Hide resolved
beeb
beeb requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@beeb beeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things!

KirienzoEth
KirienzoEth approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@KirienzoEth KirienzoEth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@samooyo samooyo merged commit c9e48b1 into feature/sepolia-deployment Aug 14, 2024
5 checks passed
@samooyo samooyo deleted the feature/sepolia-deployment-script branch August 14, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirienzoEth KirienzoEth KirienzoEth approved these changes

@beeb beeb beeb approved these changes

Assignees

@samooyo samooyo

Labels
2 reviews required To review The pull request need to be reviewed before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samooyo @beeb @KirienzoEth