Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
guillaume-chervet committed Dec 7, 2023
1 parent 2f36803 commit 9a83623
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions demo/deployment-slimfaas.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
serviceAccountName: slimfaas
containers:
- name: slimfaas
image: axaguildev/slimfaas:pr-24-248
image: axaguildev/slimfaas:pr-24-249
livenessProbe:
httpGet:
path: /health
Expand All @@ -34,7 +34,7 @@ spec:
- name: BASE_FUNCTION_URL
value: "http://{function_name}.slimfaas-demo.svc.cluster.local:5000"
- name: BASE_SLIMDATA_URL
value: "http://{pod_name}.slimfaas-demo.svc.cluster.local:3262/"
value: "http://{pod_ip}:3262/"
- name: NAMESPACE
value: "slimfaas-demo"
- name: SLIMDATA_DIRECTORY
Expand Down
3 changes: 1 addition & 2 deletions src/SlimFaas/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,6 @@
Startup startup = new(builder.Configuration);
var slimFaasPorts = EnvironmentVariables.ReadIntegers(EnvironmentVariables.SlimFaasPorts, EnvironmentVariables.SlimFaasPortsDefault);

startup.ConfigureServices(serviceCollectionSlimFaas);

// Node start as master if it is alone in the cluster
var coldStart = replicasService != null && replicasService.Deployments.SlimFaas.Pods.Count == 1 ? "true" : "false";
var slimDataConfiguration = new Dictionary<string, string>
Expand All @@ -158,6 +156,7 @@
{"requestJournal:expiration", "00:01:00" },
{"heartbeatThreshold", "0.6" }
};
startup.ConfigureServices(serviceCollectionSlimFaas);

builder.Host
.ConfigureAppConfiguration(builder => builder.AddInMemoryCollection(slimDataConfiguration!))

Check warning on line 162 in src/SlimFaas/Program.cs

View workflow job for this annotation

GitHub Actions / Build and analyze

Suggest using WebApplicationBuilder.Configuration instead of ConfigureAppConfiguration (https://aka.ms/aspnet/analyzers)
Expand Down

0 comments on commit 9a83623

Please sign in to comment.