Remove default nginx annotations in case another ingress controler is… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use. And remove tls definition cause it is not always needed (with traefik for instance)
|
Hi @d-matt Sorry for taking forever in getting back to you. If you add the old annotations and tls configuration to the default values, such that we retain backwards compatability, I'll happily merge the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all thank you for you work on this chart :)
I used this chart this week-end and had to fixed small things for it to work. I've made a different pull for each point. This is the one regarding the fact that not every body is using nginx as an ingress controller. For instance with traefik, you won't use the same annotations and you don't need the
tlspart in the ingress.